diff options
author | Nico Weber <nicolasweber@gmx.de> | 2014-01-09 08:27:35 (GMT) |
---|---|---|
committer | Nico Weber <nicolasweber@gmx.de> | 2014-01-09 08:27:35 (GMT) |
commit | 7338dad4fdc1244a4cf2eb05e708c4e5f4ea1b68 (patch) | |
tree | b6cb3019f063322f6f3ece49aec5e07e1475e8fa | |
parent | 685719d9562039ab3b9899591a32d33525bb8b9a (diff) | |
parent | 98a33759ddfe166ac684db4f4e1d0e174c89d2b5 (diff) | |
download | Ninja-7338dad4fdc1244a4cf2eb05e708c4e5f4ea1b68.zip Ninja-7338dad4fdc1244a4cf2eb05e708c4e5f4ea1b68.tar.gz Ninja-7338dad4fdc1244a4cf2eb05e708c4e5f4ea1b68.tar.bz2 |
Merge pull request #702 from nickhutchinson/feature/win32-escaping-fix
Don’t unnecessarily escape backslashes in Win32 paths
-rw-r--r-- | src/util.cc | 1 | ||||
-rw-r--r-- | src/util_test.cc | 8 |
2 files changed, 8 insertions, 1 deletions
diff --git a/src/util.cc b/src/util.cc index 0e4dc59..24d231f 100644 --- a/src/util.cc +++ b/src/util.cc @@ -194,7 +194,6 @@ static inline bool IsKnownShellSafeCharacter(char ch) { static inline bool IsKnownWin32SafeCharacter(char ch) { switch (ch) { - case '\\': case ' ': case '"': return false; diff --git a/src/util_test.cc b/src/util_test.cc index f6728fb..f827e5a 100644 --- a/src/util_test.cc +++ b/src/util_test.cc @@ -159,6 +159,14 @@ TEST(PathEscaping, SensiblePathsAreNotNeedlesslyEscaped) { EXPECT_EQ(path, result); } +TEST(PathEscaping, SensibleWin32PathsAreNotNeedlesslyEscaped) { + const char* path = "some\\sensible\\path\\without\\crazy\\characters.cc"; + string result; + + GetWin32EscapedString(path, &result); + EXPECT_EQ(path, result); +} + TEST(StripAnsiEscapeCodes, EscapeAtEnd) { string stripped = StripAnsiEscapeCodes("foo\33"); EXPECT_EQ("foo", stripped); |