diff options
| author | Colin Cross <ccross@android.com> | 2021-04-21 17:04:44 (GMT) |
|---|---|---|
| committer | Colin Cross <ccross@android.com> | 2021-10-12 00:23:22 (GMT) |
| commit | d2dae79908e890222d4fd4fa81c669c40f102c47 (patch) | |
| tree | b6ed850654411c8cf11ebdfa37e7c4f84c21e526 /src/build_test.cc | |
| parent | 0cd88287a4cd77d11c92c7a9b44bb15fb787a1ee (diff) | |
| download | Ninja-d2dae79908e890222d4fd4fa81c669c40f102c47.zip Ninja-d2dae79908e890222d4fd4fa81c669c40f102c47.tar.gz Ninja-d2dae79908e890222d4fd4fa81c669c40f102c47.tar.bz2 | |
Remove early return from Builder::AddTarget
Refactor Builder::AddTarget to remove an early return in a non-error
case. The next CL will add code that needs to be executed even if the
node is clean.
Change-Id: I953dc54b60b635dd75d75f8f3931970faefc5ecf
Diffstat (limited to 'src/build_test.cc')
| -rw-r--r-- | src/build_test.cc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/build_test.cc b/src/build_test.cc index 8b6dca2..8da4698 100644 --- a/src/build_test.cc +++ b/src/build_test.cc @@ -897,6 +897,14 @@ TEST_F(BuildTest, MissingTarget) { EXPECT_EQ("unknown target: 'meow'", err); } +TEST_F(BuildTest, MissingInputTarget) { + // Target is a missing input file + string err; + Dirty("in1"); + EXPECT_FALSE(builder_.AddTarget("in1", &err)); + EXPECT_EQ("'in1' missing and no known rule to make it", err); +} + TEST_F(BuildTest, MakeDirs) { string err; |