summaryrefslogtreecommitdiffstats
path: root/src/graph.cc
diff options
context:
space:
mode:
authorEvan Martin <martine@danga.com>2012-10-27 19:56:31 (GMT)
committerEvan Martin <martine@danga.com>2012-10-31 19:34:07 (GMT)
commit599d716fc78441436aebcde948886791d1988651 (patch)
treeb107e7537170683fbf215f05be1c9529fc777dba /src/graph.cc
parenteaf33ee5579bbc7ed884a2c3daaf6cb2e9c0d37d (diff)
downloadNinja-599d716fc78441436aebcde948886791d1988651.zip
Ninja-599d716fc78441436aebcde948886791d1988651.tar.gz
Ninja-599d716fc78441436aebcde948886791d1988651.tar.bz2
delete some obsolete TODOs
Diffstat (limited to 'src/graph.cc')
-rw-r--r--src/graph.cc3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/graph.cc b/src/graph.cc
index 0174e61..25b5baf 100644
--- a/src/graph.cc
+++ b/src/graph.cc
@@ -192,7 +192,7 @@ struct EdgeEnv : public Env {
virtual string LookupVariable(const string& var);
/// Given a span of Nodes, construct a list of paths suitable for a command
- /// line. XXX here is where shell-escaping of e.g spaces should happen.
+ /// line.
string MakePathList(vector<Node*>::iterator begin,
vector<Node*>::iterator end,
char sep);
@@ -214,7 +214,6 @@ string EdgeEnv::LookupVariable(const string& var) {
} else if (edge_->env_) {
return edge_->env_->LookupVariable(var);
} else {
- // XXX should we warn here?
return string();
}
}