diff options
author | Brad King <brad.king@kitware.com> | 2015-11-17 19:28:11 (GMT) |
---|---|---|
committer | Brad King <brad.king@kitware.com> | 2016-02-25 21:01:21 (GMT) |
commit | 1a8e5455939ed3f701141cc72262add9a7d75055 (patch) | |
tree | ee95c94021b3fe965c211f41d15db732c2e2c0e0 /src/graph.cc | |
parent | d1763746b65cc7349d4ed9478befdb651aa24589 (diff) | |
download | Ninja-1a8e5455939ed3f701141cc72262add9a7d75055.zip Ninja-1a8e5455939ed3f701141cc72262add9a7d75055.tar.gz Ninja-1a8e5455939ed3f701141cc72262add9a7d75055.tar.bz2 |
Remove StatIfNecessary call that is never necessary
The call to StatIfNecessary in DependencyScan::RecomputeOutputsDirty was
added by commit v1.4.0^2~7^2~1 (Share more code between CleanNode() and
RecomputeDirty(), 2013-09-02) while consolidating code paths. However,
it was needed only when called from RecomputeDirty because prior to
refactoring the CleanNode code path did not call it.
Later commit v1.6.0^2~46^2 (Let DependencyScan::RecomputeDirty() work
correclty with cyclic graphs, 2014-12-07) added back to RecomputeDirty a
loop over outputs that calls StatIfNecessary. Therefore
RecomputeOutputsDirty no longer needs to call StatIfNecessary for either
of its own callers.
Diffstat (limited to 'src/graph.cc')
-rw-r--r-- | src/graph.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/graph.cc b/src/graph.cc index 98a2c18..f1d9ca2 100644 --- a/src/graph.cc +++ b/src/graph.cc @@ -37,6 +37,7 @@ bool DependencyScan::RecomputeDirty(Edge* edge, string* err) { edge->outputs_ready_ = true; edge->deps_missing_ = false; + // Load output mtimes so we can compare them to the most recent input below. // RecomputeDirty() recursively walks the graph following the input nodes // of |edge| and the in_edges of these nodes. It uses the stat state of each // node to mark nodes as visited and doesn't traverse across nodes that have @@ -126,8 +127,6 @@ bool DependencyScan::RecomputeOutputsDirty(Edge* edge, Node* most_recent_input, string command = edge->EvaluateCommand(/*incl_rsp_file=*/true); for (vector<Node*>::iterator o = edge->outputs_.begin(); o != edge->outputs_.end(); ++o) { - if (!(*o)->StatIfNecessary(disk_interface_, err)) - return false; if (RecomputeOutputDirty(edge, most_recent_input, command, *o)) { *outputs_dirty = true; return true; |