make CanonicalizePath report an error on empty path

Fixes part of issue 121, but the fix exposed a further issue.

1 files changed, 20 insertions, 0 deletions

diff --git a/src/parsers_test.cc b/src/parsers_test.cc
index c1c33a2..a99b510 100644
--- a/src/parsers_test.cc
+++ b/src/parsers_test.cc
@@ -359,6 +359,26 @@ TEST_F(ParserTest, Errors) {
                               &err));
     EXPECT_EQ("line 4, col 10: expected newline, got ':'", err);
   }
+
+  {
+    State state;
+    ManifestParser parser(&state, NULL);
+    string err;
+    EXPECT_FALSE(parser.Parse("default $a\n", &err));
+    EXPECT_EQ("line 1, col 9: empty path", err);
+  }
+
+  {
+    State state;
+    ManifestParser parser(&state, NULL);
+    string err;
+    EXPECT_FALSE(parser.Parse("rule r\n"
+                              "  command = r\n"
+                              "build $a: r $c\n", &err));
+    // XXX the line number is wrong; we should evaluate paths in ParseEdge
+    // as we see them, not after we've read them all!
+    EXPECT_EQ("line 4, col 1: empty path", err);
+  }
 }
 
 TEST_F(ParserTest, MultipleOutputs)