diff options
| author | Kevin Robert Stravers <macocio@gmail.com> | 2019-09-24 11:24:02 (GMT) |
|---|---|---|
| committer | Kevin Robert Stravers <macocio@gmail.com> | 2019-09-28 22:15:09 (GMT) |
| commit | 04ce2ea7a2930b32655823d55a8ff9865a37d6c2 (patch) | |
| tree | 8ba0ad23e09c9bc9bf22e0c1641c819cd13d25e1 /src/util_test.cc | |
| parent | 21bd971ea9381e6c36d3a3be17a501899922ff73 (diff) | |
| download | Ninja-04ce2ea7a2930b32655823d55a8ff9865a37d6c2.zip Ninja-04ce2ea7a2930b32655823d55a8ff9865a37d6c2.tar.gz Ninja-04ce2ea7a2930b32655823d55a8ff9865a37d6c2.tar.bz2 | |
Ensure substring indexing never goes negative
With widths lower than 4, the ElideMiddle function would crash because
its substring access would wrap around and attempt to access the max
size_t value. This patch fixes that.
Diffstat (limited to 'src/util_test.cc')
| -rw-r--r-- | src/util_test.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/util_test.cc b/src/util_test.cc index d97b48c..b43788d 100644 --- a/src/util_test.cc +++ b/src/util_test.cc @@ -420,6 +420,10 @@ TEST(ElideMiddle, NothingToElide) { string input = "Nothing to elide in this short string."; EXPECT_EQ(input, ElideMiddle(input, 80)); EXPECT_EQ(input, ElideMiddle(input, 38)); + EXPECT_EQ("", ElideMiddle(input, 0)); + EXPECT_EQ(".", ElideMiddle(input, 1)); + EXPECT_EQ("..", ElideMiddle(input, 2)); + EXPECT_EQ("...", ElideMiddle(input, 3)); } TEST(ElideMiddle, ElideInTheMiddle) { |