summaryrefslogtreecommitdiffstats
path: root/src/tools/uic3/converter.cpp
diff options
context:
space:
mode:
authorQt Continuous Integration System <qt-info@nokia.com>2010-02-01 16:19:03 (GMT)
committerQt Continuous Integration System <qt-info@nokia.com>2010-02-01 16:19:03 (GMT)
commit296b2f47b652c0f200b19bf556649b56efa6f26f (patch)
tree6f3801940ef328a70a22161abb77457ea51522e4 /src/tools/uic3/converter.cpp
parent64ca7030df6189a0bc4df36473befd868c8d2ef6 (diff)
parente0fda52fde32458c4a42f04bd62b5e37f14c4bfd (diff)
downloadQt-296b2f47b652c0f200b19bf556649b56efa6f26f.zip
Qt-296b2f47b652c0f200b19bf556649b56efa6f26f.tar.gz
Qt-296b2f47b652c0f200b19bf556649b56efa6f26f.tar.bz2
Merge branch '4.6' of scm.dev.nokia.troll.no:qt/berlin-staging-1 into 4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/berlin-staging-1: optimization: get rid of QString::fromUtf16() usage document QString::fromUtf16() slowness remove duplicated calculation of length remove pointless conditionals micro-optimization optimize qhash() Designer/uic/related examples: Fix source code scanning issues II.
Diffstat (limited to 'src/tools/uic3/converter.cpp')
-rw-r--r--src/tools/uic3/converter.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/tools/uic3/converter.cpp b/src/tools/uic3/converter.cpp
index 2bf293d..e1b4b38 100644
--- a/src/tools/uic3/converter.cpp
+++ b/src/tools/uic3/converter.cpp
@@ -401,7 +401,7 @@ DomUI *Ui3Reader::generateUi4(const QDomElement &widget)
bool resolved = false;
if (objName == receiver) {
// see if it's a custom slot
- foreach (QString cs, ui_custom_slots) {
+ foreach (const QString &cs, ui_custom_slots) {
if (cs == slot) {
resolved = true;
break;
@@ -1122,7 +1122,7 @@ void Ui3Reader::createProperties(const QDomElement &n, QList<DomProperty*> *prop
if (prop->kind() == DomProperty::Set) {
QStringList flags = prop->elementSet().split(QLatin1Char('|'));
QStringList v;
- foreach (QString fl, flags) {
+ foreach (const QString &fl, flags) {
QString e = WidgetInfo::resolveEnumerator(className, fl);
if (e.isEmpty()) {
e = m_porting->renameEnumerator(className + QLatin1String("::") + fl);
@@ -1283,7 +1283,7 @@ QString Ui3Reader::fixType(const QString &t) const
QString newText = t;
//split type name on <>*& and whitespace
QStringList typeNames = t.split(QRegExp(QLatin1String("<|>|\\*|&| ")), QString::SkipEmptyParts);
- foreach(QString typeName , typeNames) {
+ foreach(const QString &typeName , typeNames) {
QString newName = fixClassName(typeName);
if( newName != typeName ) {
newText.replace(typeName, newName);