Speed up QmlGraphicsItem construction.

It's much faster to just initalize the flags in the constructor of
QmlGraphicsItemPrivate than doing a full blown QGraphicsItem::setFlags.
We can perfectly do this because QmlGraphicsItem does not listen to
any itemChange events related to those flags.

Reviewed-by: Aaron Kennedy

1 files changed, 6 insertions, 4 deletions

diff --git a/src/declarative/graphicsitems/qmlgraphicsitem_p.h b/src/declarative/graphicsitems/qmlgraphicsitem_p.h
index ca850f3..91d2119 100644
--- a/src/declarative/graphicsitems/qmlgraphicsitem_p.h
+++ b/src/declarative/graphicsitems/qmlgraphicsitem_p.h
@@ -116,6 +116,12 @@ public:
       smooth(false), keyHandler(0),
       width(0), height(0), implicitWidth(0), implicitHeight(0)
     {
+        QGraphicsItemPrivate::acceptedMouseButtons = 0;
+        QGraphicsItemPrivate::flags = QGraphicsItem::GraphicsItemFlags(
+                                      QGraphicsItem::ItemHasNoContents
+                                      | QGraphicsItem::ItemIsFocusable
+                                      | QGraphicsItem::ItemNegativeZStacksBehindParent);
+
     }
 
     void init(QmlGraphicsItem *parent)
@@ -125,10 +131,6 @@ public:
         if (parent)
             q->setParentItem(parent);
         _baselineOffset.invalidate();
-        q->setAcceptedMouseButtons(Qt::NoButton);
-        q->setFlags(QGraphicsItem::ItemHasNoContents |
-                    QGraphicsItem::ItemIsFocusable |
-                    QGraphicsItem::ItemNegativeZStacksBehindParent);
         mouseSetsFocus = false;
     }