1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
|
/****************************************************************************
**
** Copyright (C) 2014 Digia Plc and/or its subsidiary(-ies).
** Contact: http://www.qt-project.org/legal
**
** This file is part of the test suite of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:LGPL$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and Digia. For licensing terms and
** conditions see http://qt.digia.com/licensing. For further information
** use the contact form at http://qt.digia.com/contact-us.
**
** GNU Lesser General Public License Usage
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 2.1 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPL included in the
** packaging of this file. Please review the following information to
** ensure the GNU Lesser General Public License version 2.1 requirements
** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html.
**
** In addition, as a special exception, Digia gives you certain additional
** rights. These rights are described in the Digia Qt LGPL Exception
** version 1.1, included in the file LGPL_EXCEPTION.txt in this package.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 3.0 as published by the Free Software
** Foundation and appearing in the file LICENSE.GPL included in the
** packaging of this file. Please review the following information to
** ensure the GNU General Public License version 3.0 requirements will be
** met: http://www.gnu.org/copyleft/gpl.html.
**
**
** $QT_END_LICENSE$
**
****************************************************************************/
#include <QtTest/QtTest>
#include <qgraphicsitem.h>
#include <qgraphicstransform.h>
#include "../../shared/util.h"
class tst_QGraphicsTransform : public QObject {
Q_OBJECT
public slots:
void initTestCase();
void cleanupTestCase();
void init();
void cleanup();
private slots:
void scale();
void rotation();
void rotation3d_data();
void rotation3d();
void rotation3dArbitraryAxis_data();
void rotation3dArbitraryAxis();
private:
QString toString(QTransform const&);
};
// This will be called before the first test function is executed.
// It is only called once.
void tst_QGraphicsTransform::initTestCase()
{
}
// This will be called after the last test function is executed.
// It is only called once.
void tst_QGraphicsTransform::cleanupTestCase()
{
}
// This will be called before each test function is executed.
void tst_QGraphicsTransform::init()
{
}
// This will be called after every test function.
void tst_QGraphicsTransform::cleanup()
{
}
static QTransform transform2D(const QGraphicsTransform& t)
{
QMatrix4x4 m;
t.applyTo(&m);
return m.toTransform();
}
void tst_QGraphicsTransform::scale()
{
QGraphicsScale scale;
// check initial conditions
QCOMPARE(scale.xScale(), qreal(1));
QCOMPARE(scale.yScale(), qreal(1));
QCOMPARE(scale.zScale(), qreal(1));
QCOMPARE(scale.origin(), QVector3D(0, 0, 0));
scale.setOrigin(QVector3D(10, 10, 0));
QCOMPARE(scale.xScale(), qreal(1));
QCOMPARE(scale.yScale(), qreal(1));
QCOMPARE(scale.zScale(), qreal(1));
QCOMPARE(scale.origin(), QVector3D(10, 10, 0));
QMatrix4x4 t;
scale.applyTo(&t);
QCOMPARE(t, QMatrix4x4());
QCOMPARE(transform2D(scale), QTransform());
scale.setXScale(10);
scale.setOrigin(QVector3D(0, 0, 0));
QCOMPARE(scale.xScale(), qreal(10));
QCOMPARE(scale.yScale(), qreal(1));
QCOMPARE(scale.zScale(), qreal(1));
QCOMPARE(scale.origin(), QVector3D(0, 0, 0));
QTransform res;
res.scale(10, 1);
QCOMPARE(transform2D(scale), res);
QCOMPARE(transform2D(scale).map(QPointF(10, 10)), QPointF(100, 10));
scale.setOrigin(QVector3D(10, 10, 0));
QCOMPARE(transform2D(scale).map(QPointF(10, 10)), QPointF(10, 10));
QCOMPARE(transform2D(scale).map(QPointF(11, 10)), QPointF(20, 10));
scale.setYScale(2);
scale.setZScale(4.5);
scale.setOrigin(QVector3D(1, 2, 3));
QCOMPARE(scale.xScale(), qreal(10));
QCOMPARE(scale.yScale(), qreal(2));
QCOMPARE(scale.zScale(), qreal(4.5));
QCOMPARE(scale.origin(), QVector3D(1, 2, 3));
QMatrix4x4 t2;
scale.applyTo(&t2);
QCOMPARE(t2.map(QVector3D(4, 5, 6)), QVector3D(31, 8, 16.5));
// Because the origin has a non-zero z, mapping (4, 5) in 2D
// will introduce a projective component into the result.
QTransform t3 = t2.toTransform();
QCOMPARE(t3.map(QPointF(4, 5)), QPointF(31 / t3.m33(), 8 / t3.m33()));
}
// QMatrix4x4 uses float internally, whereas QTransform uses qreal.
// This can lead to issues with qFuzzyCompare() where it uses double
// precision to compare values that have no more than float precision
// after conversion from QMatrix4x4 to QTransform. The following
// definitions correct for the difference.
static inline bool fuzzyCompare(qreal p1, qreal p2)
{
// increase delta on small machines using float instead of double
if (sizeof(qreal) == sizeof(float))
return (qAbs(p1 - p2) <= 0.00003f * qMin(qAbs(p1), qAbs(p2)));
else
return (qAbs(p1 - p2) <= 0.00001f * qMin(qAbs(p1), qAbs(p2)));
}
static bool fuzzyCompare(const QTransform& t1, const QTransform& t2)
{
return fuzzyCompare(t1.m11(), t2.m11()) &&
fuzzyCompare(t1.m12(), t2.m12()) &&
fuzzyCompare(t1.m13(), t2.m13()) &&
fuzzyCompare(t1.m21(), t2.m21()) &&
fuzzyCompare(t1.m22(), t2.m22()) &&
fuzzyCompare(t1.m23(), t2.m23()) &&
fuzzyCompare(t1.m31(), t2.m31()) &&
fuzzyCompare(t1.m32(), t2.m32()) &&
fuzzyCompare(t1.m33(), t2.m33());
}
static inline bool fuzzyCompare(const QMatrix4x4& m1, const QMatrix4x4& m2)
{
bool ok = true;
for (int y = 0; y < 4; ++y)
for (int x = 0; x < 4; ++x)
ok &= fuzzyCompare(m1(y, x), m2(y, x));
return ok;
}
void tst_QGraphicsTransform::rotation()
{
QGraphicsRotation rotation;
QCOMPARE(rotation.axis(), QVector3D(0, 0, 1));
QCOMPARE(rotation.origin(), QVector3D(0, 0, 0));
QCOMPARE(rotation.angle(), (qreal)0);
rotation.setOrigin(QVector3D(10, 10, 0));
QCOMPARE(rotation.axis(), QVector3D(0, 0, 1));
QCOMPARE(rotation.origin(), QVector3D(10, 10, 0));
QCOMPARE(rotation.angle(), (qreal)0);
QMatrix4x4 t;
rotation.applyTo(&t);
QCOMPARE(t, QMatrix4x4());
QCOMPARE(transform2D(rotation), QTransform());
rotation.setAngle(40);
rotation.setOrigin(QVector3D(0, 0, 0));
QCOMPARE(rotation.axis(), QVector3D(0, 0, 1));
QCOMPARE(rotation.origin(), QVector3D(0, 0, 0));
QCOMPARE(rotation.angle(), (qreal)40);
QTransform res;
res.rotate(40);
QVERIFY(fuzzyCompare(transform2D(rotation), res));
rotation.setOrigin(QVector3D(10, 10, 0));
rotation.setAngle(90);
QCOMPARE(transform2D(rotation).map(QPointF(10, 10)), QPointF(10, 10));
QCOMPARE(transform2D(rotation).map(QPointF(20, 10)), QPointF(10, 20));
rotation.setOrigin(QVector3D(0, 0, 0));
rotation.setAngle(qQNaN());
QCOMPARE(transform2D(rotation).map(QPointF(20, 10)), QPointF(20, 10));
}
Q_DECLARE_METATYPE(Qt::Axis);
void tst_QGraphicsTransform::rotation3d_data()
{
QTest::addColumn<Qt::Axis>("axis");
QTest::addColumn<qreal>("angle");
for (int angle = 0; angle <= 360; angle++) {
QTest::newRow("test rotation on X") << Qt::XAxis << qreal(angle);
QTest::newRow("test rotation on Y") << Qt::YAxis << qreal(angle);
QTest::newRow("test rotation on Z") << Qt::ZAxis << qreal(angle);
}
}
void tst_QGraphicsTransform::rotation3d()
{
QFETCH(Qt::Axis, axis);
QFETCH(qreal, angle);
QGraphicsRotation rotation;
rotation.setAxis(axis);
QMatrix4x4 t;
rotation.applyTo(&t);
QVERIFY(t.isIdentity());
QVERIFY(transform2D(rotation).isIdentity());
rotation.setAngle(angle);
// QGraphicsRotation uses a correct mathematical rotation in 3D.
// QTransform's Qt::YAxis rotation is inverted from the mathematical
// version of rotation. We correct for that here.
QTransform expected;
if (axis == Qt::YAxis && angle != 180.)
expected.rotate(-angle, axis);
else
expected.rotate(angle, axis);
QVERIFY(fuzzyCompare(transform2D(rotation), expected));
// Check that "rotation" produces the 4x4 form of the 3x3 matrix.
// i.e. third row and column are 0 0 1 0.
t.setToIdentity();
rotation.applyTo(&t);
QMatrix4x4 r(expected);
if (sizeof(qreal) == sizeof(float) && angle == 268) {
// This test fails, on only this angle, when qreal == float
// because the deg2rad value in QTransform is not accurate
// enough to match what QMatrix4x4 is doing.
} else {
QVERIFY(fuzzyCompare(t, r));
}
//now let's check that a null vector will not change the transform
rotation.setAxis(QVector3D(0, 0, 0));
rotation.setOrigin(QVector3D(10, 10, 0));
t.setToIdentity();
rotation.applyTo(&t);
QVERIFY(t.isIdentity());
QVERIFY(transform2D(rotation).isIdentity());
rotation.setAngle(angle);
QVERIFY(t.isIdentity());
QVERIFY(transform2D(rotation).isIdentity());
rotation.setOrigin(QVector3D(0, 0, 0));
QVERIFY(t.isIdentity());
QVERIFY(transform2D(rotation).isIdentity());
}
QByteArray labelForTest(QVector3D const& axis, int angle) {
return QString("rotation of %1 on (%2, %3, %4)")
.arg(angle)
.arg(axis.x())
.arg(axis.y())
.arg(axis.z())
.toLatin1();
}
void tst_QGraphicsTransform::rotation3dArbitraryAxis_data()
{
QTest::addColumn<QVector3D>("axis");
QTest::addColumn<qreal>("angle");
QVector3D axis1 = QVector3D(1.0f, 1.0f, 1.0f);
QVector3D axis2 = QVector3D(2.0f, -3.0f, 0.5f);
QVector3D axis3 = QVector3D(-2.0f, 0.0f, -0.5f);
QVector3D axis4 = QVector3D(0.0001f, 0.0001f, 0.0001f);
QVector3D axis5 = QVector3D(0.01f, 0.01f, 0.01f);
for (int angle = 0; angle <= 360; angle++) {
QTest::newRow(labelForTest(axis1, angle).constData()) << axis1 << qreal(angle);
QTest::newRow(labelForTest(axis2, angle).constData()) << axis2 << qreal(angle);
QTest::newRow(labelForTest(axis3, angle).constData()) << axis3 << qreal(angle);
QTest::newRow(labelForTest(axis4, angle).constData()) << axis4 << qreal(angle);
QTest::newRow(labelForTest(axis5, angle).constData()) << axis5 << qreal(angle);
}
}
void tst_QGraphicsTransform::rotation3dArbitraryAxis()
{
QFETCH(QVector3D, axis);
QFETCH(qreal, angle);
QGraphicsRotation rotation;
rotation.setAxis(axis);
QMatrix4x4 t;
rotation.applyTo(&t);
QVERIFY(t.isIdentity());
QVERIFY(transform2D(rotation).isIdentity());
rotation.setAngle(angle);
// Compute the expected answer using QMatrix4x4 and a projection.
// These two steps are performed in one hit by QGraphicsRotation.
QMatrix4x4 exp;
exp.rotate(angle, axis);
QTransform expected = exp.toTransform(1024.0f);
#if defined(MAY_HIT_QTBUG_20661)
// These failures possibly relate to the float vs qreal issue mentioned
// in the comment above fuzzyCompare().
if (sizeof(qreal) == sizeof(double)) {
QEXPECT_FAIL("rotation of 120 on (1, 1, 1)", "QTBUG-20661", Abort);
QEXPECT_FAIL("rotation of 240 on (1, 1, 1)", "QTBUG-20661", Abort);
QEXPECT_FAIL("rotation of 120 on (0.01, 0.01, 0.01)", "QTBUG-20661", Abort);
QEXPECT_FAIL("rotation of 240 on (0.01, 0.01, 0.01)", "QTBUG-20661", Abort);
QEXPECT_FAIL("rotation of 120 on (0.0001, 0.0001, 0.0001)", "QTBUG-20661", Abort);
QEXPECT_FAIL("rotation of 240 on (0.0001, 0.0001, 0.0001)", "QTBUG-20661", Abort);
}
#endif
QTransform actual = transform2D(rotation);
QVERIFY2(fuzzyCompare(actual, expected), qPrintable(
QString("\nactual: %1\n"
"expected: %2")
.arg(toString(actual))
.arg(toString(expected))
));
// Check that "rotation" produces the 4x4 form of the 3x3 matrix.
// i.e. third row and column are 0 0 1 0.
t.setToIdentity();
rotation.applyTo(&t);
QMatrix4x4 r(expected);
QVERIFY(qFuzzyCompare(t, r));
}
QString tst_QGraphicsTransform::toString(QTransform const& t)
{
return QString("[ [ %1 %2 %3 ]; [ %4 %5 %6 ]; [ %7 %8 %9 ] ]")
.arg(t.m11())
.arg(t.m12())
.arg(t.m13())
.arg(t.m21())
.arg(t.m22())
.arg(t.m23())
.arg(t.m31())
.arg(t.m32())
.arg(t.m33())
;
}
QTEST_MAIN(tst_QGraphicsTransform)
#include "tst_qgraphicstransform.moc"
|