summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <vstinner@redhat.com>2018-09-07 15:20:42 (GMT)
committerGitHub <noreply@github.com>2018-09-07 15:20:42 (GMT)
commit012f5b968a738b15ae9b40c499a1c0778b0615a9 (patch)
tree2bf6fcfbd6a3d21b0a15663044a0396d062ae9ee
parent23e65b25557f957af840cf8fe68e80659ce28629 (diff)
downloadcpython-012f5b968a738b15ae9b40c499a1c0778b0615a9.zip
cpython-012f5b968a738b15ae9b40c499a1c0778b0615a9.tar.gz
cpython-012f5b968a738b15ae9b40c499a1c0778b0615a9.tar.bz2
bpo-34605, libregrtest: Rename --slaveargs to --worker-args (GH-9099)
Rename also run_tests_slave() to run_tests_worker().
-rw-r--r--Lib/test/libregrtest/cmdline.py2
-rw-r--r--Lib/test/libregrtest/main.py6
-rw-r--r--Lib/test/libregrtest/runtest_mp.py14
-rw-r--r--Lib/test/test_regrtest.py8
4 files changed, 15 insertions, 15 deletions
diff --git a/Lib/test/libregrtest/cmdline.py b/Lib/test/libregrtest/cmdline.py
index dab17c3..bd126b3 100644
--- a/Lib/test/libregrtest/cmdline.py
+++ b/Lib/test/libregrtest/cmdline.py
@@ -170,7 +170,7 @@ def _create_parser():
group.add_argument('--wait', action='store_true',
help='wait for user input, e.g., allow a debugger '
'to be attached')
- group.add_argument('--slaveargs', metavar='ARGS')
+ group.add_argument('--worker-args', metavar='ARGS')
group.add_argument('-S', '--start', metavar='START',
help='the name of the test at which to start.' +
more_details)
diff --git a/Lib/test/libregrtest/main.py b/Lib/test/libregrtest/main.py
index e262a7a..a176db5 100644
--- a/Lib/test/libregrtest/main.py
+++ b/Lib/test/libregrtest/main.py
@@ -542,9 +542,9 @@ class Regrtest:
print(msg, file=sys.stderr, flush=True)
sys.exit(2)
- if self.ns.slaveargs is not None:
- from test.libregrtest.runtest_mp import run_tests_slave
- run_tests_slave(self.ns.slaveargs)
+ if self.ns.worker_args is not None:
+ from test.libregrtest.runtest_mp import run_tests_worker
+ run_tests_worker(self.ns.worker_args)
if self.ns.wait:
input("Press any key to continue...")
diff --git a/Lib/test/libregrtest/runtest_mp.py b/Lib/test/libregrtest/runtest_mp.py
index 907451c..1f07cfb 100644
--- a/Lib/test/libregrtest/runtest_mp.py
+++ b/Lib/test/libregrtest/runtest_mp.py
@@ -24,23 +24,23 @@ WAIT_PROGRESS = 2.0 # seconds
def run_test_in_subprocess(testname, ns):
- """Run the given test in a subprocess with --slaveargs.
+ """Run the given test in a subprocess with --worker-args.
ns is the option Namespace parsed from command-line arguments. regrtest
- is invoked in a subprocess with the --slaveargs argument; when the
+ is invoked in a subprocess with the --worker-args argument; when the
subprocess exits, its return code, stdout and stderr are returned as a
3-tuple.
"""
from subprocess import Popen, PIPE
ns_dict = vars(ns)
- slaveargs = (ns_dict, testname)
- slaveargs = json.dumps(slaveargs)
+ worker_args = (ns_dict, testname)
+ worker_args = json.dumps(worker_args)
cmd = [sys.executable, *support.args_from_interpreter_flags(),
'-u', # Unbuffered stdout and stderr
'-m', 'test.regrtest',
- '--slaveargs', slaveargs]
+ '--worker-args', worker_args]
if ns.pgo:
cmd += ['--pgo']
@@ -58,8 +58,8 @@ def run_test_in_subprocess(testname, ns):
return retcode, stdout, stderr
-def run_tests_slave(slaveargs):
- ns_dict, testname = json.loads(slaveargs)
+def run_tests_worker(worker_args):
+ ns_dict, testname = json.loads(worker_args)
ns = types.SimpleNamespace(**ns_dict)
setup_tests(ns)
diff --git a/Lib/test/test_regrtest.py b/Lib/test/test_regrtest.py
index af332ad..f923311 100644
--- a/Lib/test/test_regrtest.py
+++ b/Lib/test/test_regrtest.py
@@ -67,10 +67,10 @@ class ParseArgsTestCase(unittest.TestCase):
ns = libregrtest._parse_args(['--wait'])
self.assertTrue(ns.wait)
- def test_slaveargs(self):
- ns = libregrtest._parse_args(['--slaveargs', '[[], {}]'])
- self.assertEqual(ns.slaveargs, '[[], {}]')
- self.checkError(['--slaveargs'], 'expected one argument')
+ def test_worker_args(self):
+ ns = libregrtest._parse_args(['--worker-args', '[[], {}]'])
+ self.assertEqual(ns.worker_args, '[[], {}]')
+ self.checkError(['--worker-args'], 'expected one argument')
def test_start(self):
for opt in '-S', '--start':