diff options
author | Victor Stinner <vstinner@redhat.com> | 2018-11-30 14:03:53 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-11-30 14:03:53 (GMT) |
commit | 1600f60414e620c4298c15dac803427d8f0a977c (patch) | |
tree | 3f202891b24688921c33c71879140df12f85b587 | |
parent | b7c2182604d5796b5af4c837991aa0b8c8a2d41f (diff) | |
download | cpython-1600f60414e620c4298c15dac803427d8f0a977c.zip cpython-1600f60414e620c4298c15dac803427d8f0a977c.tar.gz cpython-1600f60414e620c4298c15dac803427d8f0a977c.tar.bz2 |
Fix compiler warning in call_readline() (GH-10820)
Replace strncpy() with memcpy() in call_readline() to fix the
following warning, the NUL byte is written manually just after:
Modules/readline.c: In function ‘call_readline’:
Modules/readline.c:1303:9: warning: ‘strncpy’ output truncated before
terminating nul copying as many bytes from a string as its length
[-Wstringop-truncation]
strncpy(p, q, n);
^~~~~~~~~~~~~~~~
Modules/readline.c:1279:9: note: length computed here
n = strlen(p);
^~~~~~~~~
-rw-r--r-- | Modules/readline.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Modules/readline.c b/Modules/readline.c index 7756e6b..7f366aa 100644 --- a/Modules/readline.c +++ b/Modules/readline.c @@ -1240,7 +1240,7 @@ static char * call_readline(FILE *sys_stdin, FILE *sys_stdout, const char *prompt) { size_t n; - char *p, *q; + char *p; int signal; #ifdef SAVE_LOCALE @@ -1297,10 +1297,10 @@ call_readline(FILE *sys_stdin, FILE *sys_stdout, const char *prompt) } /* Copy the malloc'ed buffer into a PyMem_Malloc'ed one and release the original. */ - q = p; + char *q = p; p = PyMem_RawMalloc(n+2); if (p != NULL) { - strncpy(p, q, n); + memcpy(p, q, n); p[n] = '\n'; p[n+1] = '\0'; } |