summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEthan Furman <ethan@stoneleaf.us>2024-01-17 17:47:11 (GMT)
committerGitHub <noreply@github.com>2024-01-17 17:47:11 (GMT)
commit33b47a2c2853066b549f242065f6c2e12e18b33b (patch)
tree6ef2f63139508a88109a8b0fc209dac0f878c81d
parent029ecee10dcb7c88382849f0220dba58a654e303 (diff)
downloadcpython-33b47a2c2853066b549f242065f6c2e12e18b33b.zip
cpython-33b47a2c2853066b549f242065f6c2e12e18b33b.tar.gz
cpython-33b47a2c2853066b549f242065f6c2e12e18b33b.tar.bz2
gh-114149: [Enum] fix tuple subclass handling when using custom __new__ (GH-114160)
-rw-r--r--Lib/enum.py6
-rw-r--r--Lib/test/test_enum.py16
-rw-r--r--Misc/NEWS.d/next/Library/2024-01-16-15-59-06.gh-issue-114149.LJ8IPm.rst1
3 files changed, 20 insertions, 3 deletions
diff --git a/Lib/enum.py b/Lib/enum.py
index a8a50a5..e51850d 100644
--- a/Lib/enum.py
+++ b/Lib/enum.py
@@ -250,7 +250,7 @@ class _proto_member:
delattr(enum_class, member_name)
# second step: create member based on enum_class
value = self.value
- if not isinstance(value, tuple):
+ if type(value) is not tuple:
args = (value, )
else:
args = value
@@ -1777,7 +1777,7 @@ def _simple_enum(etype=Enum, *, boundary=None, use_args=None):
else:
# create the member
if use_args:
- if not isinstance(value, tuple):
+ if type(value) is not tuple:
value = (value, )
member = new_member(enum_class, *value)
value = value[0]
@@ -1826,7 +1826,7 @@ def _simple_enum(etype=Enum, *, boundary=None, use_args=None):
else:
# create the member
if use_args:
- if not isinstance(value, tuple):
+ if type(value) is not tuple:
value = (value, )
member = new_member(enum_class, *value)
value = value[0]
diff --git a/Lib/test/test_enum.py b/Lib/test/test_enum.py
index f99d4ca..48e0b02 100644
--- a/Lib/test/test_enum.py
+++ b/Lib/test/test_enum.py
@@ -3201,6 +3201,22 @@ class TestSpecial(unittest.TestCase):
[x.value for x in NTEnum],
[TTuple(id=0, a=0, blist=[]), TTuple(id=1, a=2, blist=[4]), TTuple(id=2, a=4, blist=[0, 1, 2])],
)
+ #
+ class NTDEnum(Enum):
+ def __new__(cls, t_value):
+ member = object.__new__(cls)
+ member._value_ = t_value[0]
+ member.id = t_value[0]
+ member.a = t_value[1]
+ member.blist = t_value[2]
+ return member
+ NONE = TTuple(0, 0, [])
+ A = TTuple(1, 2, [4])
+ B = TTuple(2, 4, [0, 1, 2])
+ self.assertEqual(repr(NTDEnum.NONE), "<NTDEnum.NONE: 0>")
+ self.assertEqual(NTDEnum.NONE.id, 0)
+ self.assertEqual(NTDEnum.A.a, 2)
+ self.assertEqual(NTDEnum.B.blist, [0, 1 ,2])
def test_flag_with_custom_new(self):
class FlagFromChar(IntFlag):
diff --git a/Misc/NEWS.d/next/Library/2024-01-16-15-59-06.gh-issue-114149.LJ8IPm.rst b/Misc/NEWS.d/next/Library/2024-01-16-15-59-06.gh-issue-114149.LJ8IPm.rst
new file mode 100644
index 0000000..1403d78
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2024-01-16-15-59-06.gh-issue-114149.LJ8IPm.rst
@@ -0,0 +1 @@
+Enum: correctly handle tuple subclasses in custom ``__new__``.