diff options
| author | Guido van Rossum <guido@python.org> | 1997-11-14 22:24:28 (GMT) |
|---|---|---|
| committer | Guido van Rossum <guido@python.org> | 1997-11-14 22:24:28 (GMT) |
| commit | 359bcaa539d9bbb2b008b5fd0a76c758b489bed5 (patch) | |
| tree | e6c5cb83090ef2a2cffcbb18f0ec5db28111a960 | |
| parent | c9fd600640229af8381f207b7d9224ba86db7206 (diff) | |
| download | cpython-359bcaa539d9bbb2b008b5fd0a76c758b489bed5.zip cpython-359bcaa539d9bbb2b008b5fd0a76c758b489bed5.tar.gz cpython-359bcaa539d9bbb2b008b5fd0a76c758b489bed5.tar.bz2 | |
This fix (across 4 files in 3 directories) solves a subtle problem with
signal handlers in a fork()ed child process when Python is compiled with
thread support. The bug was reported by Scott <scott@chronis.icgroup.com>.
What happens is that after a fork(), the variables used by the signal
module to determine whether this is the main thread or not are bogus,
and it decides that no thread is the main thread, so no signals will
be delivered.
The solution is the addition of PyOS_AfterFork(), which fixes the signal
module's variables. A dummy version of the function is present in the
intrcheck.c source file which is linked when the signal module is not
used.
| -rw-r--r-- | Include/intrcheck.h | 1 | ||||
| -rw-r--r-- | Modules/posixmodule.c | 1 | ||||
| -rw-r--r-- | Modules/signalmodule.c | 9 | ||||
| -rw-r--r-- | Parser/intrcheck.c | 5 |
4 files changed, 16 insertions, 0 deletions
diff --git a/Include/intrcheck.h b/Include/intrcheck.h index f9658e2..8566051 100644 --- a/Include/intrcheck.h +++ b/Include/intrcheck.h @@ -37,6 +37,7 @@ PERFORMANCE OF THIS SOFTWARE. extern int PyOS_InterruptOccurred Py_PROTO((void)); extern void PyOS_InitInterrupts Py_PROTO((void)); +void PyOS_AfterFork Py_PROTO((void)); #ifdef __cplusplus } diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index e06827a..58111ef 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -1082,6 +1082,7 @@ posix_fork(self, args) pid = fork(); if (pid == -1) return posix_error(); + PyOS_AfterFork(); return PyInt_FromLong((long)pid); } #endif diff --git a/Modules/signalmodule.c b/Modules/signalmodule.c index e815492..e91c3cb 100644 --- a/Modules/signalmodule.c +++ b/Modules/signalmodule.c @@ -613,3 +613,12 @@ PyOS_InterruptOccurred() } return 0; } + +void +PyOS_AfterFork() +{ +#ifdef WITH_THREAD + main_thread = get_thread_ident(); + main_pid = getpid(); +#endif +} diff --git a/Parser/intrcheck.c b/Parser/intrcheck.c index a2a3145..7fe6205 100644 --- a/Parser/intrcheck.c +++ b/Parser/intrcheck.c @@ -219,3 +219,8 @@ PyOS_InterruptOccurred() } #endif /* !OK */ + +void +PyOS_AfterFork() +{ +} |