diff options
| author | Senthil Kumaran <orsenthil@gmail.com> | 2009-04-02 03:02:03 (GMT) |
|---|---|---|
| committer | Senthil Kumaran <orsenthil@gmail.com> | 2009-04-02 03:02:03 (GMT) |
| commit | 3e2ea79bdaa6be1337b34f8da03f8c42dfe43d2f (patch) | |
| tree | c8dfbdea3199a296fd204945c1255c4c83d7eaec | |
| parent | b868a66ccb9cde89d934a896fe3c5629ed007d42 (diff) | |
| download | cpython-3e2ea79bdaa6be1337b34f8da03f8c42dfe43d2f.zip cpython-3e2ea79bdaa6be1337b34f8da03f8c42dfe43d2f.tar.gz cpython-3e2ea79bdaa6be1337b34f8da03f8c42dfe43d2f.tar.bz2 | |
Fixing the issue4860. Escaping the embedded '"' in the js_output method of Morsel class.
| -rw-r--r-- | Lib/http/cookies.py | 2 | ||||
| -rw-r--r-- | Lib/test/test_http_cookies.py | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/Lib/http/cookies.py b/Lib/http/cookies.py index 03d1627..695161a 100644 --- a/Lib/http/cookies.py +++ b/Lib/http/cookies.py @@ -392,7 +392,7 @@ class Morsel(dict): document.cookie = \"%s\"; // end hiding --> </script> - """ % ( self.OutputString(attrs), ) + """ % ( self.OutputString(attrs).replace('"',r'\"')) # end js_output() def OutputString(self, attrs=None): diff --git a/Lib/test/test_http_cookies.py b/Lib/test/test_http_cookies.py index 01017e1..158dd63 100644 --- a/Lib/test/test_http_cookies.py +++ b/Lib/test/test_http_cookies.py @@ -50,17 +50,17 @@ class CookieTests(unittest.TestCase): self.assertEqual(C.output(['path']), 'Set-Cookie: Customer="WILE_E_COYOTE"; Path=/acme') - self.assertEqual(C.js_output(), """ + self.assertEqual(C.js_output(), r""" <script type="text/javascript"> <!-- begin hiding - document.cookie = "Customer="WILE_E_COYOTE"; Path=/acme; Version=1"; + document.cookie = "Customer=\"WILE_E_COYOTE\"; Path=/acme; Version=1"; // end hiding --> </script> """) - self.assertEqual(C.js_output(['path']), """ + self.assertEqual(C.js_output(['path']), r""" <script type="text/javascript"> <!-- begin hiding - document.cookie = "Customer="WILE_E_COYOTE"; Path=/acme"; + document.cookie = "Customer=\"WILE_E_COYOTE\"; Path=/acme"; // end hiding --> </script> """) |