diff options
| author | Jelle Zijlstra <jelle.zijlstra@gmail.com> | 2023-08-27 00:13:33 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-08-27 00:13:33 (GMT) |
| commit | 482fad7f01567447b7259ebf58d62999fcdc5964 (patch) | |
| tree | cee619319091ab69b76b61c4ead8a740c82523c1 | |
| parent | 2b15536fa94d07e9e286826c23507402313ec7f4 (diff) | |
| download | cpython-482fad7f01567447b7259ebf58d62999fcdc5964.zip cpython-482fad7f01567447b7259ebf58d62999fcdc5964.tar.gz cpython-482fad7f01567447b7259ebf58d62999fcdc5964.tar.bz2 | |
gh-108295: Fix crashes with TypeVar weakrefs (#108517)
| -rw-r--r-- | Lib/test/test_typing.py | 10 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/Library/2023-08-26-08-38-57.gh-issue-108295.Pn0QRM.rst | 1 | ||||
| -rw-r--r-- | Objects/typevarobject.c | 3 |
3 files changed, 14 insertions, 0 deletions
diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py index 38baf95..6447ed6 100644 --- a/Lib/test/test_typing.py +++ b/Lib/test/test_typing.py @@ -544,6 +544,16 @@ class TypeVarTests(BaseTestCase): with self.assertRaises(TypeError): list[T][arg] + def test_many_weakrefs(self): + # gh-108295: this used to segfault + for cls in (ParamSpec, TypeVarTuple, TypeVar): + with self.subTest(cls=cls): + vals = weakref.WeakValueDictionary() + + for x in range(100000): + vals[x] = cls(str(x)) + del vals + def template_replace(templates: list[str], replacements: dict[str, list[str]]) -> list[tuple[str]]: """Renders templates with possible combinations of replacements. diff --git a/Misc/NEWS.d/next/Library/2023-08-26-08-38-57.gh-issue-108295.Pn0QRM.rst b/Misc/NEWS.d/next/Library/2023-08-26-08-38-57.gh-issue-108295.Pn0QRM.rst new file mode 100644 index 0000000..7e61ed4 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2023-08-26-08-38-57.gh-issue-108295.Pn0QRM.rst @@ -0,0 +1 @@ +Fix crashes related to use of weakrefs on :data:`typing.TypeVar`. diff --git a/Objects/typevarobject.c b/Objects/typevarobject.c index 66122e3..ef1803d 100644 --- a/Objects/typevarobject.c +++ b/Objects/typevarobject.c @@ -201,6 +201,7 @@ typevar_dealloc(PyObject *self) Py_XDECREF(tv->constraints); Py_XDECREF(tv->evaluate_constraints); _PyObject_ClearManagedDict(self); + PyObject_ClearWeakRefs(self); Py_TYPE(self)->tp_free(self); Py_DECREF(tp); @@ -743,6 +744,7 @@ paramspec_dealloc(PyObject *self) Py_DECREF(ps->name); Py_XDECREF(ps->bound); _PyObject_ClearManagedDict(self); + PyObject_ClearWeakRefs(self); Py_TYPE(self)->tp_free(self); Py_DECREF(tp); @@ -1022,6 +1024,7 @@ typevartuple_dealloc(PyObject *self) Py_DECREF(tvt->name); _PyObject_ClearManagedDict(self); + PyObject_ClearWeakRefs(self); Py_TYPE(self)->tp_free(self); Py_DECREF(tp); |