summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@gmail.com>2015-01-15 13:24:22 (GMT)
committerVictor Stinner <victor.stinner@gmail.com>2015-01-15 13:24:22 (GMT)
commit4bf22e033e975f61c33752db5a3764dc0f7d0b03 (patch)
tree268ed6b1243135e2b55cad6d59907a0ca33e5ae5
parentfcd58de78f72ca114707b78e448397d6dbe2ad5d (diff)
downloadcpython-4bf22e033e975f61c33752db5a3764dc0f7d0b03.zip
cpython-4bf22e033e975f61c33752db5a3764dc0f7d0b03.tar.gz
cpython-4bf22e033e975f61c33752db5a3764dc0f7d0b03.tar.bz2
asyncio: Close the transport on subprocess creation failure
-rw-r--r--Lib/asyncio/unix_events.py6
-rw-r--r--Lib/asyncio/windows_events.py7
2 files changed, 11 insertions, 2 deletions
diff --git a/Lib/asyncio/unix_events.py b/Lib/asyncio/unix_events.py
index 9f4005c..97f9add 100644
--- a/Lib/asyncio/unix_events.py
+++ b/Lib/asyncio/unix_events.py
@@ -177,7 +177,11 @@ class _UnixSelectorEventLoop(selector_events.BaseSelectorEventLoop):
transp = _UnixSubprocessTransport(self, protocol, args, shell,
stdin, stdout, stderr, bufsize,
extra=extra, **kwargs)
- yield from transp._post_init()
+ try:
+ yield from transp._post_init()
+ except:
+ transp.close()
+ raise
watcher.add_child_handler(transp.get_pid(),
self._child_watcher_callback, transp)
diff --git a/Lib/asyncio/windows_events.py b/Lib/asyncio/windows_events.py
index 9d496f2..82d0966 100644
--- a/Lib/asyncio/windows_events.py
+++ b/Lib/asyncio/windows_events.py
@@ -272,7 +272,12 @@ class ProactorEventLoop(proactor_events.BaseProactorEventLoop):
transp = _WindowsSubprocessTransport(self, protocol, args, shell,
stdin, stdout, stderr, bufsize,
extra=extra, **kwargs)
- yield from transp._post_init()
+ try:
+ yield from transp._post_init()
+ except:
+ transp.close()
+ raise
+
return transp