summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAntoine Pitrou <solipsis@pitrou.net>2010-09-21 16:08:27 (GMT)
committerAntoine Pitrou <solipsis@pitrou.net>2010-09-21 16:08:27 (GMT)
commit52d42503d5f7e763264b03f12785c46a467c196b (patch)
tree5a906c1cafd489974fa28dc89b52d5bde70e7d69
parente31f7d9e2e7e3ada5bbc912d4c752fa9ce4c4f7e (diff)
downloadcpython-52d42503d5f7e763264b03f12785c46a467c196b.zip
cpython-52d42503d5f7e763264b03f12785c46a467c196b.tar.gz
cpython-52d42503d5f7e763264b03f12785c46a467c196b.tar.bz2
Issue #2643: msync() is not called anymore when deallocating an open mmap
object, only munmap().
-rw-r--r--Misc/NEWS3
-rw-r--r--Modules/mmapmodule.c1
2 files changed, 3 insertions, 1 deletions
diff --git a/Misc/NEWS b/Misc/NEWS
index 139ab01..cdd9ef7 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -58,6 +58,9 @@ Core and Builtins
Library
-------
+- Issue #2643: msync() is not called anymore when deallocating an open mmap
+ object, only munmap().
+
- logging: Changed LoggerAdapter implementation internally, to make it
easier to subclass in a useful way.
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
index 8c5c8ac..3413f17 100644
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -125,7 +125,6 @@ mmap_object_dealloc(mmap_object *m_obj)
if (m_obj->fd >= 0)
(void) close(m_obj->fd);
if (m_obj->data!=NULL) {
- msync(m_obj->data, m_obj->size, MS_SYNC);
munmap(m_obj->data, m_obj->size);
}
#endif /* UNIX */