summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLysandros Nikolaou <lisandrosnik@gmail.com>2018-11-04 21:21:28 (GMT)
committerNed Deily <nad@python.org>2018-11-04 21:21:28 (GMT)
commit59668aa8b7f174b59304eab833c1c1181886c3c6 (patch)
tree296db0d3b9c775c76c7fb9bf3e7e3bd50faea8e0
parentc03bf0ae794c3bec9b56f38164535fd1f5bfc04a (diff)
downloadcpython-59668aa8b7f174b59304eab833c1c1181886c3c6.zip
cpython-59668aa8b7f174b59304eab833c1c1181886c3c6.tar.gz
cpython-59668aa8b7f174b59304eab833c1c1181886c3c6.tar.bz2
bpo-21263: Skip test_gdb when python has been compiled with LLVM clang (GH-10318)
-rw-r--r--Lib/test/test_gdb.py5
-rw-r--r--Misc/ACKS1
-rw-r--r--Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst4
3 files changed, 10 insertions, 0 deletions
diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py
index 0f950b2..711fb69 100644
--- a/Lib/test/test_gdb.py
+++ b/Lib/test/test_gdb.py
@@ -5,6 +5,7 @@
import locale
import os
+import platform
import re
import subprocess
import sys
@@ -48,6 +49,10 @@ if gdb_major_version < 7:
if not sysconfig.is_python_build():
raise unittest.SkipTest("test_gdb only works on source builds at the moment.")
+if 'Clang' in platform.python_compiler() and sys.platform == 'darwin':
+ raise unittest.SkipTest("test_gdb doesn't work correctly when python is"
+ " built with LLVM clang")
+
# Location of custom hooks file in a repository checkout.
checkout_hook_path = os.path.join(os.path.dirname(sys.executable),
'python-gdb.py')
diff --git a/Misc/ACKS b/Misc/ACKS
index 08ff6d1..89fb0c7 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1147,6 +1147,7 @@ Samuel Nicolary
Jonathan Niehof
Gustavo Niemeyer
Oscar Nierstrasz
+Lysandros Nikolaou
Hrvoje Nikšić
Gregory Nofi
Jesse Noller
diff --git a/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst b/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst
new file mode 100644
index 0000000..9c6b4ef
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2018-11-04-20-17-09.bpo-21263.T3qo9r.rst
@@ -0,0 +1,4 @@
+After several reports that test_gdb does not work properly on macOS and
+since gdb is not shipped by default anymore, test_gdb is now skipped on
+macOS when LLVM Clang has been used to compile Python. Patch by
+Lysandros Nikolaou