summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristian Heimes <christian@python.org>2016-10-13 19:10:31 (GMT)
committerChristian Heimes <christian@python.org>2016-10-13 19:10:31 (GMT)
commit5cade88ac1cf9241a8052c68646beac08aaa718e (patch)
tree0423d1d775a4c59224feb32d020b616ac27bbedb
parent2ccdb5a4f1469284cd18693b7e828af5d8a4f737 (diff)
downloadcpython-5cade88ac1cf9241a8052c68646beac08aaa718e.zip
cpython-5cade88ac1cf9241a8052c68646beac08aaa718e.tar.gz
cpython-5cade88ac1cf9241a8052c68646beac08aaa718e.tar.bz2
Check return value of _PyDict_SetItemId()
-rw-r--r--Objects/typeobject.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index 1960c1a..1021a75 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -2848,13 +2848,16 @@ PyType_FromSpecWithBases(PyType_Spec *spec, PyObject *bases)
/* Set type.__module__ */
s = strrchr(spec->name, '.');
if (s != NULL) {
+ int err;
modname = PyUnicode_FromStringAndSize(
spec->name, (Py_ssize_t)(s - spec->name));
if (modname == NULL) {
goto fail;
}
- _PyDict_SetItemId(type->tp_dict, &PyId___module__, modname);
+ err = _PyDict_SetItemId(type->tp_dict, &PyId___module__, modname);
Py_DECREF(modname);
+ if (err != 0)
+ goto fail;
} else {
if (PyErr_WarnFormat(PyExc_DeprecationWarning, 1,
"builtin type %.200s has no __module__ attribute",