summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2025-01-12 13:14:46 (GMT)
committerGitHub <noreply@github.com>2025-01-12 13:14:46 (GMT)
commit5e65a1acc0b630397f1d190aed279114e6e99612 (patch)
treed2141cd4f419ed640a7c442a3ae4a28a33ede497
parentf6c61bf2d7d8b66ccd9f16e723546bdcc251a3d0 (diff)
downloadcpython-5e65a1acc0b630397f1d190aed279114e6e99612.zip
cpython-5e65a1acc0b630397f1d190aed279114e6e99612.tar.gz
cpython-5e65a1acc0b630397f1d190aed279114e6e99612.tar.bz2
gh-128731: Fix ResourceWarning in robotparser.RobotFileParser.read() (GH-128733)
-rw-r--r--Lib/urllib/robotparser.py1
-rw-r--r--Misc/NEWS.d/next/Library/2025-01-11-13-40-12.gh-issue-128731.qpKlai.rst1
2 files changed, 2 insertions, 0 deletions
diff --git a/Lib/urllib/robotparser.py b/Lib/urllib/robotparser.py
index c58565e..24ee198 100644
--- a/Lib/urllib/robotparser.py
+++ b/Lib/urllib/robotparser.py
@@ -65,6 +65,7 @@ class RobotFileParser:
self.disallow_all = True
elif err.code >= 400 and err.code < 500:
self.allow_all = True
+ err.close()
else:
raw = f.read()
self.parse(raw.decode("utf-8").splitlines())
diff --git a/Misc/NEWS.d/next/Library/2025-01-11-13-40-12.gh-issue-128731.qpKlai.rst b/Misc/NEWS.d/next/Library/2025-01-11-13-40-12.gh-issue-128731.qpKlai.rst
new file mode 100644
index 0000000..b23499c
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2025-01-11-13-40-12.gh-issue-128731.qpKlai.rst
@@ -0,0 +1 @@
+Fix :exc:`ResourceWarning` in :meth:`urllib.robotparser.RobotFileParser.read`.