summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGiampaolo Rodola' <g.rodola@gmail.com>2012-12-31 16:23:09 (GMT)
committerGiampaolo Rodola' <g.rodola@gmail.com>2012-12-31 16:23:09 (GMT)
commit5e844c8052d13202261c2eb95f07802615c66921 (patch)
tree70f364bbcc6647be36754755c791762ebd091f9b
parentc7ce3f7be5e72cf2253fc997bfdb6c80e27400f8 (diff)
downloadcpython-5e844c8052d13202261c2eb95f07802615c66921.zip
cpython-5e844c8052d13202261c2eb95f07802615c66921.tar.gz
cpython-5e844c8052d13202261c2eb95f07802615c66921.tar.bz2
Fix issue 10527: make multiprocessing use poll() instead of select() if available.
-rw-r--r--Lib/multiprocessing/connection.py21
-rw-r--r--Lib/test/test_multiprocessing.py1
-rw-r--r--Misc/NEWS2
3 files changed, 24 insertions, 0 deletions
diff --git a/Lib/multiprocessing/connection.py b/Lib/multiprocessing/connection.py
index 4fa6f70..f083c54 100644
--- a/Lib/multiprocessing/connection.py
+++ b/Lib/multiprocessing/connection.py
@@ -213,6 +213,27 @@ if sys.platform != 'win32':
return c1, c2
else:
+ if hasattr(select, 'poll'):
+ def _poll(fds, timeout):
+ if timeout is not None:
+ timeout = int(timeout) * 1000 # timeout is in milliseconds
+ fd_map = {}
+ pollster = select.poll()
+ for fd in fds:
+ pollster.register(fd, select.POLLIN)
+ if hasattr(fd, 'fileno'):
+ fd_map[fd.fileno()] = fd
+ else:
+ fd_map[fd] = fd
+ ls = []
+ for fd, event in pollster.poll(timeout):
+ if event & select.POLLNVAL:
+ raise ValueError('invalid file descriptor %i' % fd)
+ ls.append(fd_map[fd])
+ return ls
+ else:
+ def _poll(fds, timeout):
+ return select.select(fds, [], [], timeout)[0]
from _multiprocessing import win32
diff --git a/Lib/test/test_multiprocessing.py b/Lib/test/test_multiprocessing.py
index ab6d36a..fa4865b 100644
--- a/Lib/test/test_multiprocessing.py
+++ b/Lib/test/test_multiprocessing.py
@@ -1574,6 +1574,7 @@ class _TestConnection(BaseTestCase):
self.assertTimingAlmostEqual(poll.elapsed, TIMEOUT1)
conn.send(None)
+ time.sleep(.1)
self.assertEqual(poll(TIMEOUT1), True)
self.assertTimingAlmostEqual(poll.elapsed, 0)
diff --git a/Misc/NEWS b/Misc/NEWS
index 8ce30c5..9e04951 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -189,6 +189,8 @@ Core and Builtins
Library
-------
+- Issue 10527: make multiprocessing use poll() instead of select() if available.
+
- Issue #16485: Fix file descriptor not being closed if file header patching
fails on closing of aifc file.