summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <vstinner@python.org>2023-09-29 00:01:24 (GMT)
committerGitHub <noreply@github.com>2023-09-29 00:01:24 (GMT)
commit5fdcea744024c8a19ddb57057bf5ec2889546c98 (patch)
treecb3954ee35ec6f10684fc0e352d47e1d993f86f6
parentb488c0d761b2018c10bc5a0e5469b8b209e1a681 (diff)
downloadcpython-5fdcea744024c8a19ddb57057bf5ec2889546c98.zip
cpython-5fdcea744024c8a19ddb57057bf5ec2889546c98.tar.gz
cpython-5fdcea744024c8a19ddb57057bf5ec2889546c98.tar.bz2
gh-109960: Remove test_pty timeout of 10 seconds (#110058)
In 2003, test_pty got a hardcoded timeout of 10 seconds to prevent hanging on AIX & HPUX "if run after test_openpty": commit 7d8145268ee282f14d6adce9305dc3c1c7ffec14. Since 2003, test_pty was no longer reported to hang on AIX. But today, the test can fail simply because a CI is busy running other tests in parallel. The timeout of 10 seconds is no longer needed, just remove it. Moreover, regrtest now has multiple built-in generic timeout mecanisms.
-rw-r--r--Lib/test/test_pty.py11
1 files changed, 0 insertions, 11 deletions
diff --git a/Lib/test/test_pty.py b/Lib/test/test_pty.py
index c9c2b42..a971f6b 100644
--- a/Lib/test/test_pty.py
+++ b/Lib/test/test_pty.py
@@ -80,17 +80,9 @@ def expectedFailureIfStdinIsTTY(fun):
# because pty code is not too portable.
class PtyTest(unittest.TestCase):
def setUp(self):
- old_alarm = signal.signal(signal.SIGALRM, self.handle_sig)
- self.addCleanup(signal.signal, signal.SIGALRM, old_alarm)
-
old_sighup = signal.signal(signal.SIGHUP, self.handle_sighup)
self.addCleanup(signal.signal, signal.SIGHUP, old_sighup)
- # isatty() and close() can hang on some platforms. Set an alarm
- # before running the test to make sure we don't hang forever.
- self.addCleanup(signal.alarm, 0)
- signal.alarm(10)
-
# Save original stdin window size.
self.stdin_dim = None
if _HAVE_WINSZ:
@@ -101,9 +93,6 @@ class PtyTest(unittest.TestCase):
except tty.error:
pass
- def handle_sig(self, sig, frame):
- self.fail("isatty hung")
-
@staticmethod
def handle_sighup(signum, frame):
pass