diff options
author | Benjamin Peterson <benjamin@python.org> | 2016-09-14 05:46:45 (GMT) |
---|---|---|
committer | Benjamin Peterson <benjamin@python.org> | 2016-09-14 05:46:45 (GMT) |
commit | 66c8dfb56522087d22b550bff15c914bea54f182 (patch) | |
tree | 69210895e7138b692f5442eaf4f4d893eca1376e | |
parent | 995026a8a97b49c3fa3d7d4abce14455347e42a9 (diff) | |
parent | b3cde6dd0bf3b5d151110c1c5699984b3b068764 (diff) | |
download | cpython-66c8dfb56522087d22b550bff15c914bea54f182.zip cpython-66c8dfb56522087d22b550bff15c914bea54f182.tar.gz cpython-66c8dfb56522087d22b550bff15c914bea54f182.tar.bz2 |
merge heads
-rw-r--r-- | Lib/test/test_zipimport.py | 13 | ||||
-rw-r--r-- | Misc/NEWS | 3 | ||||
-rw-r--r-- | Modules/zipimport.c | 2 |
3 files changed, 17 insertions, 1 deletions
diff --git a/Lib/test/test_zipimport.py b/Lib/test/test_zipimport.py index a7e680d..7ddbc50 100644 --- a/Lib/test/test_zipimport.py +++ b/Lib/test/test_zipimport.py @@ -532,6 +532,19 @@ class UncompressedZipImportTestCase(ImportHooksBaseTestCase): "some.data": (NOW, "some data")} self.doTest(pyc_ext, files, TESTMOD) + def testDefaultOptimizationLevel(self): + # zipimport should use the default optimization level (#28131) + src = """if 1: # indent hack + def test(val): + assert(val) + return val\n""" + files = {TESTMOD + '.py': (NOW, src)} + self.makeZip(files) + sys.path.insert(0, TEMP_ZIP) + mod = importlib.import_module(TESTMOD) + self.assertEqual(mod.test(1), 1) + self.assertRaises(AssertionError, mod.test, False) + def testImport_WithStuff(self): # try importing from a zipfile which contains additional # stuff at the beginning of the file @@ -10,6 +10,9 @@ What's New in Python 3.6.0 beta 2 Core and Builtins ----------------- +- Issue #28131: Fix a regression in zipimport's compile_source(). zipimport + should use the same optimization level as the interpreter. + - Issue #28126: Replace Py_MEMCPY with memcpy(). Visual Studio can properly optimize memcpy(). diff --git a/Modules/zipimport.c b/Modules/zipimport.c index 92a82e6..7473a8f 100644 --- a/Modules/zipimport.c +++ b/Modules/zipimport.c @@ -1370,7 +1370,7 @@ compile_source(PyObject *pathname, PyObject *source) } code = Py_CompileStringObject(PyBytes_AsString(fixed_source), - pathname, Py_file_input, NULL, 1); + pathname, Py_file_input, NULL, -1); Py_DECREF(fixed_source); return code; |