diff options
| author | Guido van Rossum <guido@python.org> | 1997-08-14 19:57:39 (GMT) |
|---|---|---|
| committer | Guido van Rossum <guido@python.org> | 1997-08-14 19:57:39 (GMT) |
| commit | 6d8841c0794144d4e3f398040cb9eb9f5ac8d320 (patch) | |
| tree | b7220eff246c3c801bc9ad8ff3d6f8ed24972d69 | |
| parent | 0d2390c5495bd1e8e90161f5322ea34b55fd570f (diff) | |
| download | cpython-6d8841c0794144d4e3f398040cb9eb9f5ac8d320.zip cpython-6d8841c0794144d4e3f398040cb9eb9f5ac8d320.tar.gz cpython-6d8841c0794144d4e3f398040cb9eb9f5ac8d320.tar.bz2 | |
Added a bunch of XXX comments about things I'd like to see changed...
| -rw-r--r-- | Modules/posixmodule.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index c19f394..ff1d114 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -67,6 +67,7 @@ corresponding Unix manual entries for more information on calls."; #endif /* HAVE_FCNTL_H */ /* Various compilers have only certain posix functions */ +/* XXX Gosh I wish these were all moved into config.h */ #ifdef __WATCOMC__ /* Watcom compiler */ #define HAVE_GETCWD 1 #define HAVE_OPENDIR 1 @@ -479,6 +480,8 @@ posix_listdir(self, args) PyObject *self; PyObject *args; { + /* XXX Should redo this putting the three versions of opendir + in separate files instead of having them all here... */ #if defined(MS_WIN32) && !defined(HAVE_OPENDIR) char *name; @@ -832,6 +835,7 @@ posix_utime(self, args) long atime, mtime; int res; +/* XXX should define struct utimbuf instead, above */ #ifdef HAVE_UTIME_H struct utimbuf buf; #define ATIME buf.actime @@ -2222,7 +2226,8 @@ all_ins(d) } - +/* XXX The following should be more unified -- only difference left is + function name and module name. */ #if defined(_MSC_VER) || defined(__WATCOMC__) void @@ -2254,6 +2259,7 @@ initnt() return; finally: + /* XXX Shouldn't */ Py_FatalError("can't initialize NT posixmodule"); } #else /* not a PC port */ @@ -2286,6 +2292,7 @@ initposix() return; finally: + /* XXX Shouldn't */ Py_FatalError("can't initialize posix module"); } #endif /* !_MSC_VER */ |