summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@gmail.com>2017-12-12 22:15:00 (GMT)
committerGitHub <noreply@github.com>2017-12-12 22:15:00 (GMT)
commit721e25c6535d08bd3d4d891fb2b540472e19f899 (patch)
treece7e3b202b33bfeeda4469c6992fe8c4a065312c
parent747f48e2e92390c44c72f52a1239959601cde157 (diff)
downloadcpython-721e25c6535d08bd3d4d891fb2b540472e19f899.zip
cpython-721e25c6535d08bd3d4d891fb2b540472e19f899.tar.gz
cpython-721e25c6535d08bd3d4d891fb2b540472e19f899.tar.bz2
bpo-32101: Fix tests for PYTHONDEVMODE=1 (#4821)
test_asycio: remove also aio_path which was used when asyncio was developed outside the stdlib.
-rw-r--r--Lib/test/test_asyncio/test_base_events.py7
-rw-r--r--Lib/test/test_asyncio/test_tasks.py12
-rw-r--r--Lib/test/test_faulthandler.py14
3 files changed, 16 insertions, 17 deletions
diff --git a/Lib/test/test_asyncio/test_base_events.py b/Lib/test/test_asyncio/test_base_events.py
index 8b08ed1..e43fe69 100644
--- a/Lib/test/test_asyncio/test_base_events.py
+++ b/Lib/test/test_asyncio/test_base_events.py
@@ -802,17 +802,20 @@ class BaseEventLoopTests(test_utils.TestCase):
self.assertEqual(stdout.rstrip(), b'False')
sts, stdout, stderr = assert_python_ok('-c', code,
- PYTHONASYNCIODEBUG='')
+ PYTHONASYNCIODEBUG='',
+ PYTHONDEVMODE='')
self.assertEqual(stdout.rstrip(), b'False')
sts, stdout, stderr = assert_python_ok('-c', code,
- PYTHONASYNCIODEBUG='1')
+ PYTHONASYNCIODEBUG='1',
+ PYTHONDEVMODE='')
self.assertEqual(stdout.rstrip(), b'True')
sts, stdout, stderr = assert_python_ok('-E', '-c', code,
PYTHONASYNCIODEBUG='1')
self.assertEqual(stdout.rstrip(), b'False')
+ # -X dev
sts, stdout, stderr = assert_python_ok('-E', '-X', 'dev',
'-c', code)
self.assertEqual(stdout.rstrip(), b'True')
diff --git a/Lib/test/test_asyncio/test_tasks.py b/Lib/test/test_asyncio/test_tasks.py
index 071481d..0838ebf 100644
--- a/Lib/test/test_asyncio/test_tasks.py
+++ b/Lib/test/test_asyncio/test_tasks.py
@@ -2257,33 +2257,31 @@ class GatherTestsBase:
self.assertEqual(fut.result(), [3, 1, exc, exc2])
def test_env_var_debug(self):
- aio_path = os.path.dirname(os.path.dirname(asyncio.__file__))
-
code = '\n'.join((
'import asyncio.coroutines',
'print(asyncio.coroutines._DEBUG)'))
# Test with -E to not fail if the unit test was run with
# PYTHONASYNCIODEBUG set to a non-empty string
- sts, stdout, stderr = assert_python_ok('-E', '-c', code,
- PYTHONPATH=aio_path)
+ sts, stdout, stderr = assert_python_ok('-E', '-c', code)
self.assertEqual(stdout.rstrip(), b'False')
sts, stdout, stderr = assert_python_ok('-c', code,
PYTHONASYNCIODEBUG='',
- PYTHONPATH=aio_path)
+ PYTHONDEVMODE='')
self.assertEqual(stdout.rstrip(), b'False')
sts, stdout, stderr = assert_python_ok('-c', code,
PYTHONASYNCIODEBUG='1',
- PYTHONPATH=aio_path)
+ PYTHONDEVMODE='')
self.assertEqual(stdout.rstrip(), b'True')
sts, stdout, stderr = assert_python_ok('-E', '-c', code,
PYTHONASYNCIODEBUG='1',
- PYTHONPATH=aio_path)
+ PYTHONDEVMODE='')
self.assertEqual(stdout.rstrip(), b'False')
+ # -X dev
sts, stdout, stderr = assert_python_ok('-E', '-X', 'dev',
'-c', code)
self.assertEqual(stdout.rstrip(), b'True')
diff --git a/Lib/test/test_faulthandler.py b/Lib/test/test_faulthandler.py
index 3647bfc..d6dc4ba 100644
--- a/Lib/test/test_faulthandler.py
+++ b/Lib/test/test_faulthandler.py
@@ -332,13 +332,9 @@ class FaultHandlerTests(unittest.TestCase):
def test_disabled_by_default(self):
# By default, the module should be disabled
code = "import faulthandler; print(faulthandler.is_enabled())"
- args = filter(None, (sys.executable,
- "-E" if sys.flags.ignore_environment else "",
- "-c", code))
- env = os.environ.copy()
- env.pop("PYTHONFAULTHANDLER", None)
+ args = (sys.executable, "-E", "-c", code)
# don't use assert_python_ok() because it always enables faulthandler
- output = subprocess.check_output(args, env=env)
+ output = subprocess.check_output(args)
self.assertEqual(output.rstrip(), b"False")
def test_sys_xoptions(self):
@@ -357,15 +353,17 @@ class FaultHandlerTests(unittest.TestCase):
# empty env var
code = "import faulthandler; print(faulthandler.is_enabled())"
args = (sys.executable, "-c", code)
- env = os.environ.copy()
+ env = dict(os.environ)
env['PYTHONFAULTHANDLER'] = ''
+ env['PYTHONDEVMODE'] = ''
# don't use assert_python_ok() because it always enables faulthandler
output = subprocess.check_output(args, env=env)
self.assertEqual(output.rstrip(), b"False")
# non-empty env var
- env = os.environ.copy()
+ env = dict(os.environ)
env['PYTHONFAULTHANDLER'] = '1'
+ env['PYTHONDEVMODE'] = ''
output = subprocess.check_output(args, env=env)
self.assertEqual(output.rstrip(), b"True")