diff options
| author | Victor Stinner <victor.stinner@gmail.com> | 2017-05-15 15:55:32 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-05-15 15:55:32 (GMT) |
| commit | 79ef7f8e88a4972c4aecf95cfc5cd934f1861e08 (patch) | |
| tree | 4446c0ecfef41d5ecd549c4062d9a9ed8ea7d2e7 | |
| parent | 83a2c2879839da2e10037f5e4af1bd1dafbf1a52 (diff) | |
| download | cpython-79ef7f8e88a4972c4aecf95cfc5cd934f1861e08.zip cpython-79ef7f8e88a4972c4aecf95cfc5cd934f1861e08.tar.gz cpython-79ef7f8e88a4972c4aecf95cfc5cd934f1861e08.tar.bz2 | |
bpo-30357: test_thread now uses threading_cleanup() (#1592)
test_thread: setUp() now uses support.threading_setup() and
support.threading_cleanup() to wait until threads complete to avoid
random side effects on following tests.
Co-Authored-By: Grzegorz Grzywacz <grzegorz.grzywacz@nazwa.pl>
| -rw-r--r-- | Lib/test/test_thread.py | 4 | ||||
| -rw-r--r-- | Misc/ACKS | 1 | ||||
| -rw-r--r-- | Misc/NEWS | 5 |
3 files changed, 10 insertions, 0 deletions
diff --git a/Lib/test/test_thread.py b/Lib/test/test_thread.py index ef3059b..3909b75 100644 --- a/Lib/test/test_thread.py +++ b/Lib/test/test_thread.py @@ -20,6 +20,7 @@ def verbose_print(arg): with _print_mutex: print(arg) + class BasicThreadTest(unittest.TestCase): def setUp(self): @@ -31,6 +32,9 @@ class BasicThreadTest(unittest.TestCase): self.running = 0 self.next_ident = 0 + key = support.threading_setup() + self.addCleanup(support.threading_cleanup, *key) + class ThreadRunningTests(BasicThreadTest): @@ -555,6 +555,7 @@ Eric Groo Daniel Andrade Groppe Dag Gruneau Filip Gruszczyński +Grzegorz Grzywacz Thomas Guettler Yuyang Guo Anuj Gupta @@ -1183,6 +1183,11 @@ Tools/Demos Tests ----- +* bpo-30357: test_thread: setUp() now uses support.threading_setup() and + support.threading_cleanup() to wait until threads complete to avoid + random side effects on following tests. Initial patch written by Grzegorz + Grzywacz. + - bpo-30197: Enhanced functions swap_attr() and swap_item() in the test.support module. They now work when delete replaced attribute or item inside the with statement. The old value of the attribute or item (or None |