summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormpage <mpage@meta.com>2024-05-01 20:59:12 (GMT)
committerGitHub <noreply@github.com>2024-05-01 20:59:12 (GMT)
commit8a50544a998764b8a315b316ceadaebdc748d8fe (patch)
treee0c529ff272772315525d896a09d410b77bd2849
parent6763bfcc0fbab7895514c1f954d79a2555036323 (diff)
downloadcpython-8a50544a998764b8a315b316ceadaebdc748d8fe.zip
cpython-8a50544a998764b8a315b316ceadaebdc748d8fe.tar.gz
cpython-8a50544a998764b8a315b316ceadaebdc748d8fe.tar.bz2
gh-118433: Temporarily skip `test_interrupt_main_subthread` in free-threaded builds (#118485)
Free-threaded builds can intermittently tickle a longstanding bug (24 years!) in the implementation of `threading.Condition`, leading to flakiness in the test suite. Fixing the underlying issue will require more discussion, and will likely apply to most of the concurrency primitives in the `threading` module that are written in Python. See gh-118433 for more details.
-rw-r--r--Lib/test/test_threading.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py
index 362a3f9..0047e8a 100644
--- a/Lib/test/test_threading.py
+++ b/Lib/test/test_threading.py
@@ -3,7 +3,7 @@ Tests for the threading module.
"""
import test.support
-from test.support import threading_helper, requires_subprocess
+from test.support import threading_helper, requires_subprocess, requires_gil_enabled
from test.support import verbose, cpython_only, os_helper
from test.support.import_helper import import_module
from test.support.script_helper import assert_python_ok, assert_python_failure
@@ -2025,6 +2025,7 @@ class InterruptMainTests(unittest.TestCase):
# Restore original handler
signal.signal(signum, handler)
+ @requires_gil_enabled("gh-118433: Flaky due to a longstanding bug")
def test_interrupt_main_subthread(self):
# Calling start_new_thread with a function that executes interrupt_main
# should raise KeyboardInterrupt upon completion.