diff options
| author | Brian Curtin <brian@python.org> | 2012-12-27 20:12:43 (GMT) |
|---|---|---|
| committer | Brian Curtin <brian@python.org> | 2012-12-27 20:12:43 (GMT) |
| commit | 9eac6b3848d6f6a59187199520144709ddcb3567 (patch) | |
| tree | 5de3a3e1be8be1e1811f2d1f123bec028b5feaaf | |
| parent | 07e0e06f8a255a73d181e332dd8658814eb1ca50 (diff) | |
| parent | 172e42295fa846bb253f698da10150906f723f52 (diff) | |
| download | cpython-9eac6b3848d6f6a59187199520144709ddcb3567.zip cpython-9eac6b3848d6f6a59187199520144709ddcb3567.tar.gz cpython-9eac6b3848d6f6a59187199520144709ddcb3567.tar.bz2 | |
Merge
| -rw-r--r-- | Lib/test/test_winreg.py | 17 | ||||
| -rw-r--r-- | Misc/NEWS | 4 | ||||
| -rw-r--r-- | PC/winreg.c | 4 |
3 files changed, 23 insertions, 2 deletions
diff --git a/Lib/test/test_winreg.py b/Lib/test/test_winreg.py index 68c12eb..a164d2f 100644 --- a/Lib/test/test_winreg.py +++ b/Lib/test/test_winreg.py @@ -335,6 +335,23 @@ class LocalWinregTests(BaseWinregTests): finally: DeleteKey(HKEY_CURRENT_USER, test_key_name) + def test_queryvalueex_return_value(self): + # Test for Issue #16759, return unsigned int from QueryValueEx. + # Reg2Py, which gets called by QueryValueEx, was returning a value + # generated by PyLong_FromLong. The implmentation now uses + # PyLong_FromUnsignedLong to match DWORD's size. + try: + with CreateKey(HKEY_CURRENT_USER, test_key_name) as ck: + self.assertNotEqual(ck.handle, 0) + test_val = 0x80000000 + SetValueEx(ck, "test_name", None, REG_DWORD, test_val) + ret_val, ret_type = QueryValueEx(ck, "test_name") + self.assertEqual(ret_type, REG_DWORD) + self.assertEqual(ret_val, test_val) + finally: + DeleteKey(HKEY_CURRENT_USER, test_key_name) + + @unittest.skipUnless(REMOTE_NAME, "Skipping remote registry tests") class RemoteWinregTests(BaseWinregTests): @@ -10,6 +10,10 @@ What's New in Python 3.2.4 Core and Builtins ----------------- +- Issue #16759: Support the full DWORD (unsigned long) range in Reg2Py + when retreiving a REG_DWORD value. This corrects functions like + winreg.QueryValueEx that may have been returning truncated values. + - Issue #14420: Support the full DWORD (unsigned long) range in Py2Reg when passed a REG_DWORD value. Fixes OverflowError in winreg.SetValueEx. diff --git a/PC/winreg.c b/PC/winreg.c index 523ad17..e4b9307 100644 --- a/PC/winreg.c +++ b/PC/winreg.c @@ -900,9 +900,9 @@ Reg2Py(BYTE *retDataBuf, DWORD retDataSize, DWORD typ) switch (typ) { case REG_DWORD: if (retDataSize == 0) - obData = PyLong_FromLong(0); + obData = PyLong_FromUnsignedLong(0); else - obData = PyLong_FromLong(*(int *)retDataBuf); + obData = PyLong_FromUnsignedLong(*(int *)retDataBuf); break; case REG_SZ: case REG_EXPAND_SZ: |