diff options
| author | Senthil Kumaran <senthil@uthcode.com> | 2011-07-04 04:03:16 (GMT) |
|---|---|---|
| committer | Senthil Kumaran <senthil@uthcode.com> | 2011-07-04 04:03:16 (GMT) |
| commit | 9ebe08d2f6c3b8bca5148e909cc89efeb7a01ad1 (patch) | |
| tree | 14b187f19e9c85236091dd81dcfabcfcd4db3682 | |
| parent | a55007a620792a6dff946ee04b1295689e70b616 (diff) | |
| download | cpython-9ebe08d2f6c3b8bca5148e909cc89efeb7a01ad1.zip cpython-9ebe08d2f6c3b8bca5148e909cc89efeb7a01ad1.tar.gz cpython-9ebe08d2f6c3b8bca5148e909cc89efeb7a01ad1.tar.bz2 | |
Fix closes issue12471 - wrong TypeError message when '%i' format spec was used.
| -rw-r--r-- | Lib/test/test_unicode.py | 1 | ||||
| -rw-r--r-- | Objects/unicodeobject.c | 4 |
2 files changed, 2 insertions, 3 deletions
diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py index 97be587..885e740 100644 --- a/Lib/test/test_unicode.py +++ b/Lib/test/test_unicode.py @@ -788,6 +788,7 @@ class UnicodeTest(string_tests.CommonTest, self.assertEqual('%c' % '\U00021483', '\U00021483') self.assertRaises(TypeError, "%c".__mod__, "aa") self.assertRaises(ValueError, "%.1\u1032f".__mod__, (1.0/3)) + self.assertRaises(TypeError, "%i".__mod__, "aa") # formatting jobs delegated from the string implementation: self.assertEqual('...%(foo)s...' % {'foo':"abc"}, '...abc...') diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c index 7a70a5e..03807a4 100644 --- a/Objects/unicodeobject.c +++ b/Objects/unicodeobject.c @@ -9689,8 +9689,6 @@ PyObject *PyUnicode_Format(PyObject *format, case 'o': case 'x': case 'X': - if (c == 'i') - c = 'd'; isnumok = 0; if (PyNumber_Check(v)) { PyObject *iobj=NULL; @@ -9705,7 +9703,7 @@ PyObject *PyUnicode_Format(PyObject *format, if (iobj!=NULL) { if (PyLong_Check(iobj)) { isnumok = 1; - temp = formatlong(iobj, flags, prec, c); + temp = formatlong(iobj, flags, prec, (c == 'i'? 'd': c)); Py_DECREF(iobj); if (!temp) goto onError; |