summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKristján Valur Jónsson <kristjan@ccpgames.com>2012-12-25 22:46:32 (GMT)
committerKristján Valur Jónsson <kristjan@ccpgames.com>2012-12-25 22:46:32 (GMT)
commitb0d1c37d737742eb098b985475987f460a13a6c2 (patch)
treed87fcaac580feb5a429ed92a42a77fc1901c6cc5
parentc08ded9e4a3073e6f6315d0fa462debdb6d28304 (diff)
downloadcpython-b0d1c37d737742eb098b985475987f460a13a6c2.zip
cpython-b0d1c37d737742eb098b985475987f460a13a6c2.tar.gz
cpython-b0d1c37d737742eb098b985475987f460a13a6c2.tar.bz2
Issue #14574: Ignore socket errors raised when flushing a connection on close.
-rw-r--r--Doc/library/socketserver.rst4
-rw-r--r--Lib/SocketServer.py7
2 files changed, 8 insertions, 3 deletions
diff --git a/Doc/library/socketserver.rst b/Doc/library/socketserver.rst
index c34b486..d225392 100644
--- a/Doc/library/socketserver.rst
+++ b/Doc/library/socketserver.rst
@@ -306,8 +306,8 @@ request.
.. method:: RequestHandler.finish()
Called after the :meth:`handle` method to perform any clean-up actions
- required. The default implementation does nothing. If :meth:`setup` or
- :meth:`handle` raise an exception, this function will not be called.
+ required. The default implementation does nothing. If :meth:`setup`
+ raises an exception, this function will not be called.
.. method:: RequestHandler.handle()
diff --git a/Lib/SocketServer.py b/Lib/SocketServer.py
index 1594321..26611b7 100644
--- a/Lib/SocketServer.py
+++ b/Lib/SocketServer.py
@@ -701,7 +701,12 @@ class StreamRequestHandler(BaseRequestHandler):
def finish(self):
if not self.wfile.closed:
- self.wfile.flush()
+ try:
+ self.wfile.flush()
+ except socket.error:
+ # An final socket error may have occurred here, such as
+ # the local error ECONNABORTED.
+ pass
self.wfile.close()
self.rfile.close()