diff options
| author | Victor Stinner <vstinner@redhat.com> | 2019-07-03 09:09:56 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-03 09:09:56 (GMT) |
| commit | b71d8d67959f3b5efbdfe00066589ac0d8f98aad (patch) | |
| tree | 8d1e014f3de495666fceccb81562b3a46182c18c | |
| parent | 0f6f73ff3c2e46144884c4d418e67939a042aa23 (diff) | |
| download | cpython-b71d8d67959f3b5efbdfe00066589ac0d8f98aad.zip cpython-b71d8d67959f3b5efbdfe00066589ac0d8f98aad.tar.gz cpython-b71d8d67959f3b5efbdfe00066589ac0d8f98aad.tar.bz2 | |
bpo-37421: test_winconsoleio doesn't leak temp file anymore (GH-14562)
test_winconsoleio doesn't leak a temporary file anymore: use
tempfile.TemporaryFile() to remove it when the test completes.
| -rw-r--r-- | Lib/test/test_winconsoleio.py | 6 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/Tests/2019-07-02-23-20-35.bpo-37421.HCkKWz.rst | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/Lib/test/test_winconsoleio.py b/Lib/test/test_winconsoleio.py index a78fa4d..9a61e48 100644 --- a/Lib/test/test_winconsoleio.py +++ b/Lib/test/test_winconsoleio.py @@ -25,14 +25,12 @@ class WindowsConsoleIOTests(unittest.TestCase): self.assertRaisesRegex(ValueError, "negative file descriptor", ConIO, -1) - fd, _ = tempfile.mkstemp() - try: + with tempfile.TemporaryFile() as tmpfile: + fd = tmpfile.fileno() # Windows 10: "Cannot open non-console file" # Earlier: "Cannot open console output buffer for reading" self.assertRaisesRegex(ValueError, "Cannot open (console|non-console file)", ConIO, fd) - finally: - os.close(fd) try: f = ConIO(0) diff --git a/Misc/NEWS.d/next/Tests/2019-07-02-23-20-35.bpo-37421.HCkKWz.rst b/Misc/NEWS.d/next/Tests/2019-07-02-23-20-35.bpo-37421.HCkKWz.rst new file mode 100644 index 0000000..6671ffe --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2019-07-02-23-20-35.bpo-37421.HCkKWz.rst @@ -0,0 +1,2 @@ +test_winconsoleio doesn't leak a temporary file anymore: use +tempfile.TemporaryFile() to remove it when the test completes. |