summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2024-06-19 13:38:37 (GMT)
committerGitHub <noreply@github.com>2024-06-19 13:38:37 (GMT)
commitbb5d19440b8056bd2b272239a2c0b1c2063b3af6 (patch)
treeb795dbe80072005850c263cbf8f0b409d410d99c
parent4ce1246a9958d2d1452f83be961e369f7d050714 (diff)
downloadcpython-bb5d19440b8056bd2b272239a2c0b1c2063b3af6.zip
cpython-bb5d19440b8056bd2b272239a2c0b1c2063b3af6.tar.gz
cpython-bb5d19440b8056bd2b272239a2c0b1c2063b3af6.tar.bz2
[3.13] gh-120635: Avoid leaking processes in test_pyrepl (GH-120676) (#120741)
gh-120635: Avoid leaking processes in test_pyrepl (GH-120676) If the child process takes longer than SHORT_TIMEOUT seconds to complete, kill the process but then wait until it completes with no timeout to not leak child processes. (cherry picked from commit 0f3e36454d754026d6c510053ff1e4b22ae80cd9) Co-authored-by: Victor Stinner <vstinner@python.org>
-rw-r--r--Lib/test/test_pyrepl/test_pyrepl.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/Lib/test/test_pyrepl/test_pyrepl.py b/Lib/test/test_pyrepl/test_pyrepl.py
index 41ba595..adc55f2 100644
--- a/Lib/test/test_pyrepl/test_pyrepl.py
+++ b/Lib/test/test_pyrepl/test_pyrepl.py
@@ -890,5 +890,5 @@ class TestMain(TestCase):
exit_code = process.wait(timeout=SHORT_TIMEOUT)
except subprocess.TimeoutExpired:
process.kill()
- exit_code = process.returncode
+ exit_code = process.wait()
return "\n".join(output), exit_code