diff options
| author | Victor Stinner <victor.stinner@gmail.com> | 2017-11-30 22:03:47 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-11-30 22:03:47 (GMT) |
| commit | c319eeeb45043ee45384b8064c53ddbfde1673cd (patch) | |
| tree | 019237a6a3750aae2d7eac6d4700b0f25c2dbd2e | |
| parent | 3be3b97a9709d3cd5303175ddbffa7dcca57ac3e (diff) | |
| download | cpython-c319eeeb45043ee45384b8064c53ddbfde1673cd.zip cpython-c319eeeb45043ee45384b8064c53ddbfde1673cd.tar.gz cpython-c319eeeb45043ee45384b8064c53ddbfde1673cd.tar.bz2 | |
Fix CID-1420310: cast PY_TIMEOUT_MAX to _Py_time_t (#4646)
Fix the following false-alarm Coverity warning:
Result is not floating-point
(UNINTENDED_INTEGER_DIVISION)integer_division: Dividing integer
expressions 9223372036854775807LL and 1000LL, and then converting
the integer quotient to type double. Any remainder, or fractional
part of the quotient, is ignored.
To compute and use a non-integer quotient, change or cast either
operand to type double. If integer division is intended, consider
indicating that by casting the result to type long long .
| -rw-r--r-- | Modules/_threadmodule.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Modules/_threadmodule.c b/Modules/_threadmodule.c index aaa13da..c9171f5 100644 --- a/Modules/_threadmodule.c +++ b/Modules/_threadmodule.c @@ -1363,7 +1363,7 @@ PyInit__thread(void) if (m == NULL) return NULL; - timeout_max = (double)PY_TIMEOUT_MAX * 1e-6; + timeout_max = (_PyTime_t)PY_TIMEOUT_MAX * 1e-6; time_max = _PyTime_AsSecondsDouble(_PyTime_MAX); timeout_max = Py_MIN(timeout_max, time_max); /* Round towards minus infinity */ |