diff options
author | Benjamin Peterson <benjamin@python.org> | 2008-11-03 15:18:30 (GMT) |
---|---|---|
committer | Benjamin Peterson <benjamin@python.org> | 2008-11-03 15:18:30 (GMT) |
commit | eeed0c78224078322ba5453607e770bad22b32db (patch) | |
tree | d044e3deda3531ec8b96186b027117a475383e84 | |
parent | 084ce7a5dcadc2d1bac565a363ae54bbcb09abd0 (diff) | |
download | cpython-eeed0c78224078322ba5453607e770bad22b32db.zip cpython-eeed0c78224078322ba5453607e770bad22b32db.tar.gz cpython-eeed0c78224078322ba5453607e770bad22b32db.tar.bz2 |
Merged revisions 67077 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/trunk
........
r67077 | benjamin.peterson | 2008-11-03 09:14:51 -0600 (Mon, 03 Nov 2008) | 1 line
#4048 make the parser module accept relative imports as valid
........
-rw-r--r-- | Lib/test/test_parser.py | 2 | ||||
-rw-r--r-- | Misc/ACKS | 1 | ||||
-rw-r--r-- | Misc/NEWS | 2 | ||||
-rw-r--r-- | Modules/parsermodule.c | 4 |
4 files changed, 7 insertions, 2 deletions
diff --git a/Lib/test/test_parser.py b/Lib/test/test_parser.py index 9ecca51..94b6113 100644 --- a/Lib/test/test_parser.py +++ b/Lib/test/test_parser.py @@ -1,4 +1,5 @@ import parser +import os import unittest import sys from test import test_support @@ -179,6 +180,7 @@ class RoundtripLegalSyntaxTestCase(unittest.TestCase): "from sys.path import (dirname, basename as my_basename)") self.check_suite( "from sys.path import (dirname, basename as my_basename,)") + self.check_suite("from .bogus import x") def test_basic_import_statement(self): self.check_suite("import sys") @@ -62,6 +62,7 @@ Eric Beser Steven Bethard Stephen Bevan Ron Bickers +David Binger Dominic Binks Philippe Biondi Stuart Bishop @@ -12,6 +12,8 @@ What's New in Python 2.6.1 alpha 1 Core and Builtins ----------------- +- Issue #4048: The parser module now correctly validates relative imports. + - Issue #4225: ``from __future__ import unicode_literals`` didn't work in an exec statement. diff --git a/Modules/parsermodule.c b/Modules/parsermodule.c index 423a0b3..bea78c2 100644 --- a/Modules/parsermodule.c +++ b/Modules/parsermodule.c @@ -1879,10 +1879,10 @@ static int count_from_dots(node *tree) { int i; - for (i = 0; i < NCH(tree); i++) + for (i = 1; i < NCH(tree); i++) if (TYPE(CHILD(tree, i)) != DOT) break; - return i; + return i-1; } /* 'from' ('.'* dotted_name | '.') 'import' ('*' | '(' import_as_names ')' | |