diff options
author | Steve Dower <steve.dower@python.org> | 2021-09-20 14:33:00 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-09-20 14:33:00 (GMT) |
commit | ef9e22b253253615098d22cb49141a2a1024ee3c (patch) | |
tree | 033240e65fd1bcb27f586262ff2cb94ad999d356 | |
parent | a856364cc920d8b16750fd1fadc902efb509754c (diff) | |
download | cpython-ef9e22b253253615098d22cb49141a2a1024ee3c.zip cpython-ef9e22b253253615098d22cb49141a2a1024ee3c.tar.gz cpython-ef9e22b253253615098d22cb49141a2a1024ee3c.tar.bz2 |
bpo-45055: Add retry when downloading externals on Windows (GH-28399)
Co-authored-by: Ćukasz Langa <lukasz@langa.pl>
-rwxr-xr-x | PCbuild/get_external.py | 19 |
1 files changed, 18 insertions, 1 deletions
diff --git a/PCbuild/get_external.py b/PCbuild/get_external.py index a682d38..4ecc892 100755 --- a/PCbuild/get_external.py +++ b/PCbuild/get_external.py @@ -3,6 +3,8 @@ import argparse import os import pathlib +import sys +import time import zipfile from urllib.request import urlretrieve @@ -53,7 +55,22 @@ def main(): verbose=args.verbose, ) final_name = args.externals_dir / args.tag - extract_zip(args.externals_dir, zip_path).replace(final_name) + extracted = extract_zip(args.externals_dir, zip_path) + for wait in [1, 2, 3, 5, 8, 0]: + try: + extracted.replace(final_name) + break + except PermissionError as ex: + retry = f" Retrying in {wait}s..." if wait else "" + print(f"Encountered permission error '{ex}'.{retry}", file=sys.stderr) + time.sleep(wait) + else: + print( + f"ERROR: Failed to extract {final_name}.", + "You may need to restart your build", + file=sys.stderr, + ) + sys.exit(1) if __name__ == '__main__': |