summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNikita Sobolev <mail@sobolevn.me>2023-11-19 18:30:07 (GMT)
committerGitHub <noreply@github.com>2023-11-19 18:30:07 (GMT)
commitf8129146ef9e1b71609ef4becc5d508061970733 (patch)
tree7c56f3c64c78cca42c9a175a3f12696166b9f026
parent77d9f1e6d9aad637667264c16c83d255526cc1ba (diff)
downloadcpython-f8129146ef9e1b71609ef4becc5d508061970733.zip
cpython-f8129146ef9e1b71609ef4becc5d508061970733.tar.gz
cpython-f8129146ef9e1b71609ef4becc5d508061970733.tar.bz2
gh-112266: Remove `(if defined)` part from `__dict__` and `__weakref__` docstrings (#112268)
-rw-r--r--Lib/test/test_pydoc.py28
-rw-r--r--Misc/NEWS.d/next/Core and Builtins/2023-11-19-15-57-23.gh-issue-112266.BSJMbR.rst2
-rw-r--r--Objects/typeobject.c8
3 files changed, 20 insertions, 18 deletions
diff --git a/Lib/test/test_pydoc.py b/Lib/test/test_pydoc.py
index 70c5ebd..745717f 100644
--- a/Lib/test/test_pydoc.py
+++ b/Lib/test/test_pydoc.py
@@ -43,8 +43,8 @@ class nonascii:
if test.support.HAVE_DOCSTRINGS:
expected_data_docstrings = (
- 'dictionary for instance variables (if defined)',
- 'list of weak references to the object (if defined)',
+ 'dictionary for instance variables',
+ 'list of weak references to the object',
) * 2
else:
expected_data_docstrings = ('', '', '', '')
@@ -108,10 +108,10 @@ CLASSES
| Data descriptors defined here:
|
| __dict__
- | dictionary for instance variables (if defined)
+ | dictionary for instance variables
|
| __weakref__
- | list of weak references to the object (if defined)
+ | list of weak references to the object
FUNCTIONS
doc_func()
@@ -169,16 +169,16 @@ class A(builtins.object)
Data descriptors defined here:
__dict__
- dictionary for instance variables (if defined)
+ dictionary for instance variables
__weakref__
- list of weak references to the object (if defined)
+ list of weak references to the object
class B(builtins.object)
Data descriptors defined here:
__dict__
- dictionary for instance variables (if defined)
+ dictionary for instance variables
__weakref__
- list of weak references to the object (if defined)
+ list of weak references to the object
Data and other attributes defined here:
NO_MEANING = 'eggs'
__annotations__ = {'NO_MEANING': <class 'str'>}
@@ -195,9 +195,9 @@ class C(builtins.object)
__class_getitem__(item) from builtins.type
Data descriptors defined here:
__dict__
- dictionary for instance variables (if defined)
+ dictionary for instance variables
__weakref__
- list of weak references to the object (if defined)
+ list of weak references to the object
Functions
doc_func()
@@ -829,10 +829,10 @@ class B(A)
| Data descriptors inherited from A:
|
| __dict__
- | dictionary for instance variables (if defined)
+ | dictionary for instance variables
|
| __weakref__
- | list of weak references to the object (if defined)
+ | list of weak references to the object
''' % __name__)
doc = pydoc.render_doc(B, renderer=pydoc.HTMLDoc())
@@ -861,9 +861,9 @@ class B(A)
Data descriptors inherited from A:
__dict__
- dictionary for instance variables (if defined)
+ dictionary for instance variables
__weakref__
- list of weak references to the object (if defined)
+ list of weak references to the object
"""
as_text = html2text(doc)
expected_lines = [line.strip() for line in expected_text.split("\n") if line]
diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-11-19-15-57-23.gh-issue-112266.BSJMbR.rst b/Misc/NEWS.d/next/Core and Builtins/2023-11-19-15-57-23.gh-issue-112266.BSJMbR.rst
new file mode 100644
index 0000000..18433db
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2023-11-19-15-57-23.gh-issue-112266.BSJMbR.rst
@@ -0,0 +1,2 @@
+Change docstrings of :attr:`~object.__dict__` and
+:attr:`~object.__weakref__`.
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index 4464b5a..f5975a3 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -3006,21 +3006,21 @@ subtype_getweakref(PyObject *obj, void *context)
static PyGetSetDef subtype_getsets_full[] = {
{"__dict__", subtype_dict, subtype_setdict,
- PyDoc_STR("dictionary for instance variables (if defined)")},
+ PyDoc_STR("dictionary for instance variables")},
{"__weakref__", subtype_getweakref, NULL,
- PyDoc_STR("list of weak references to the object (if defined)")},
+ PyDoc_STR("list of weak references to the object")},
{0}
};
static PyGetSetDef subtype_getsets_dict_only[] = {
{"__dict__", subtype_dict, subtype_setdict,
- PyDoc_STR("dictionary for instance variables (if defined)")},
+ PyDoc_STR("dictionary for instance variables")},
{0}
};
static PyGetSetDef subtype_getsets_weakref_only[] = {
{"__weakref__", subtype_getweakref, NULL,
- PyDoc_STR("list of weak references to the object (if defined)")},
+ PyDoc_STR("list of weak references to the object")},
{0}
};