diff options
| author | zygocephalus <grrrr@protonmail.com> | 2019-06-07 20:08:36 (GMT) |
|---|---|---|
| committer | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2019-06-07 20:08:36 (GMT) |
| commit | 03d5831a2d62c68654ec223168e574cd546efbf6 (patch) | |
| tree | e1d26a353a8269cfaf0fd2f1518bf7907c16f116 /Lib/argparse.py | |
| parent | 1f9531764cc0f8dbca1d8f429d162dc28282f4b4 (diff) | |
| download | cpython-03d5831a2d62c68654ec223168e574cd546efbf6.zip cpython-03d5831a2d62c68654ec223168e574cd546efbf6.tar.gz cpython-03d5831a2d62c68654ec223168e574cd546efbf6.tar.bz2 | |
bpo-37150: Throw ValueError if FileType class object was passed in add_argument (GH-13805)
There is a possibility that someone (like me) accidentally will omit parentheses with `FileType` arguments after `FileType`, and parser will contain wrong file until someone will try to use it.
Example:
```python
parser = argparse.ArgumentParser()
parser.add_argument('-x', type=argparse.FileType)
```
https://bugs.python.org/issue37150
Diffstat (limited to 'Lib/argparse.py')
| -rw-r--r-- | Lib/argparse.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Lib/argparse.py b/Lib/argparse.py index ef888f0..9a67b41 100644 --- a/Lib/argparse.py +++ b/Lib/argparse.py @@ -1361,6 +1361,10 @@ class _ActionsContainer(object): if not callable(type_func): raise ValueError('%r is not callable' % (type_func,)) + if type_func is FileType: + raise ValueError('%r is a FileType class object, instance of it' + ' must be passed' % (type_func,)) + # raise an error if the metavar does not match the type if hasattr(self, "_get_formatter"): try: |