summaryrefslogtreecommitdiffstats
path: root/Lib/contextlib.py
diff options
context:
space:
mode:
authorJoongi Kim <joongi@lablup.com>2020-11-02 08:02:48 (GMT)
committerGitHub <noreply@github.com>2020-11-02 08:02:48 (GMT)
commit6e8dcdaaa49d4313bf9fab9f9923ca5828fbb10e (patch)
treefc23f29d61f7fa5d98c51f5adce53c9f32a726e4 /Lib/contextlib.py
parente9208f0e74d8c37542a750476ff272143fa8f67c (diff)
downloadcpython-6e8dcdaaa49d4313bf9fab9f9923ca5828fbb10e.zip
cpython-6e8dcdaaa49d4313bf9fab9f9923ca5828fbb10e.tar.gz
cpython-6e8dcdaaa49d4313bf9fab9f9923ca5828fbb10e.tar.bz2
bpo-41229: Update docs for explicit aclose()-required cases and add contextlib.aclosing() method (GH-21545)
This is a PR to: * Add `contextlib.aclosing` which ia analogous to `contextlib.closing` but for async-generators with an explicit test case for [bpo-41229]() * Update the docs to describe when we need explicit `aclose()` invocation. which are motivated by the following issues, articles, and examples: * [bpo-41229]() * https://github.com/njsmith/async_generator * https://vorpus.org/blog/some-thoughts-on-asynchronous-api-design-in-a-post-asyncawait-world/#cleanup-in-generators-and-async-generators * https://www.python.org/dev/peps/pep-0533/ * https://github.com/achimnol/aiotools/blob/ef7bf0cea7af/src/aiotools/context.py#L152 Particuarly regarding [PEP-533](https://www.python.org/dev/peps/pep-0533/), its acceptance (`__aiterclose__()`) would make this little addition of `contextlib.aclosing()` unnecessary for most use cases, but until then this could serve as a good counterpart and analogy to `contextlib.closing()`. The same applies for `contextlib.closing` with `__iterclose__()`. Also, still there are other use cases, e.g., when working with non-generator objects with `aclose()` methods.
Diffstat (limited to 'Lib/contextlib.py')
-rw-r--r--Lib/contextlib.py26
1 files changed, 26 insertions, 0 deletions
diff --git a/Lib/contextlib.py b/Lib/contextlib.py
index ff92d9f..82ddc14 100644
--- a/Lib/contextlib.py
+++ b/Lib/contextlib.py
@@ -303,6 +303,32 @@ class closing(AbstractContextManager):
self.thing.close()
+class aclosing(AbstractAsyncContextManager):
+ """Async context manager for safely finalizing an asynchronously cleaned-up
+ resource such as an async generator, calling its ``aclose()`` method.
+
+ Code like this:
+
+ async with aclosing(<module>.fetch(<arguments>)) as agen:
+ <block>
+
+ is equivalent to this:
+
+ agen = <module>.fetch(<arguments>)
+ try:
+ <block>
+ finally:
+ await agen.aclose()
+
+ """
+ def __init__(self, thing):
+ self.thing = thing
+ async def __aenter__(self):
+ return self.thing
+ async def __aexit__(self, *exc_info):
+ await self.thing.aclose()
+
+
class _RedirectStream(AbstractContextManager):
_stream = None