diff options
author | Aaron Gallagher <habnabit@users.noreply.github.com> | 2017-07-20 00:01:14 (GMT) |
---|---|---|
committer | Berker Peksag <berker.peksag@gmail.com> | 2017-07-20 00:01:14 (GMT) |
commit | 856cbcc12f2e4cca93af5dc7ed6bcea4dd942f10 (patch) | |
tree | 16b9a0093cb7e8fe3a8f8c6886679fcea7ad3596 /Lib/datetime.py | |
parent | ed014f7e135fe021837208960237d6c37afde5be (diff) | |
download | cpython-856cbcc12f2e4cca93af5dc7ed6bcea4dd942f10.zip cpython-856cbcc12f2e4cca93af5dc7ed6bcea4dd942f10.tar.gz cpython-856cbcc12f2e4cca93af5dc7ed6bcea4dd942f10.tar.bz2 |
bpo-29403: Fix mock's broken autospec behavior on method-bound builtin functions (GH-3)
Cython will, in the right circumstances, offer a MethodType instance
where im_func is a builtin function. Any instance of MethodType is
automatically assumed to be a Python-defined function (more
specifically, a function that has an inspectable signature), but
_set_signature was still conservative in its assumptions. As a result
_set_signature would return early with None instead of a mock since
the im_func had no inspectable signature. This causes problems
deeper inside mock, as _set_signature is assumed to _always_
return a mock, and nothing checked its return value.
In similar corner cases, autospec will simply not check the spec of the
function, so _set_signature is amended to now return early with the
original, not-wrapped mock object.
Patch by Aaron Gallagher.
Diffstat (limited to 'Lib/datetime.py')
0 files changed, 0 insertions, 0 deletions