summaryrefslogtreecommitdiffstats
path: root/Lib/distutils
diff options
context:
space:
mode:
authorÉric Araujo <merwok@netwok.org>2012-02-12 03:52:21 (GMT)
committerÉric Araujo <merwok@netwok.org>2012-02-12 03:52:21 (GMT)
commit9ce366a5a691fb929c41d7f2c065bcbbddc81026 (patch)
tree74a42dec684151b10245b4a6dec5dcba0a5023ec /Lib/distutils
parent01a221572742548919e58dddc0dd916576a91884 (diff)
downloadcpython-9ce366a5a691fb929c41d7f2c065bcbbddc81026.zip
cpython-9ce366a5a691fb929c41d7f2c065bcbbddc81026.tar.gz
cpython-9ce366a5a691fb929c41d7f2c065bcbbddc81026.tar.bz2
Fix distutils.filelist.FileList under Windows (#13193).
The code used to call os.path.join to build a regex but without escaping the backslash, which lead to test failures on Windows. Antoine Pitrou fixed it in 0a94e2f807c7 by enhancing the code to accept both / and \, with proper escaping, but in my opinion this goes against the distutils feature freeze, hence this change.
Diffstat (limited to 'Lib/distutils')
-rw-r--r--Lib/distutils/filelist.py6
1 files changed, 2 insertions, 4 deletions
diff --git a/Lib/distutils/filelist.py b/Lib/distutils/filelist.py
index 87b2cc6..9122032 100644
--- a/Lib/distutils/filelist.py
+++ b/Lib/distutils/filelist.py
@@ -313,10 +313,8 @@ def translate_pattern(pattern, anchor=1, prefix=None, is_regex=0):
# ditch end of pattern character
empty_pattern = glob_to_re('')
prefix_re = (glob_to_re(prefix))[:-len(empty_pattern)]
- # match both path separators, as in Postel's principle
- sep_pat = "[" + re.escape(os.path.sep + os.path.altsep
- if os.path.altsep else os.path.sep) + "]"
- pattern_re = "^" + sep_pat.join([prefix_re, ".*" + pattern_re])
+ # paths should always use / in manifest templates
+ pattern_re = "^%s/.*%s" % (prefix_re, pattern_re)
else: # no prefix -- respect anchor flag
if anchor:
pattern_re = "^" + pattern_re