summaryrefslogtreecommitdiffstats
path: root/Lib/optparse.py
diff options
context:
space:
mode:
authorRaymond Hettinger <python@rcn.com>2008-07-10 15:37:08 (GMT)
committerRaymond Hettinger <python@rcn.com>2008-07-10 15:37:08 (GMT)
commit930795b7e02835421ef1c998d0b99ffa5e930239 (patch)
tree31969ec4e13cc1c77c948b0a71cc07f19151d5f2 /Lib/optparse.py
parent9be2ec109bcec499c1a6971fb4c40d9a8e7886fe (diff)
downloadcpython-930795b7e02835421ef1c998d0b99ffa5e930239.zip
cpython-930795b7e02835421ef1c998d0b99ffa5e930239.tar.gz
cpython-930795b7e02835421ef1c998d0b99ffa5e930239.tar.bz2
Clear the -3 warnings in optparse.py
Diffstat (limited to 'Lib/optparse.py')
-rw-r--r--Lib/optparse.py24
1 files changed, 9 insertions, 15 deletions
diff --git a/Lib/optparse.py b/Lib/optparse.py
index b4a1708..2cb21de 100644
--- a/Lib/optparse.py
+++ b/Lib/optparse.py
@@ -602,7 +602,7 @@ class Option:
def _set_attrs(self, attrs):
for attr in self.ATTRS:
- if attrs.has_key(attr):
+ if attr in attrs:
setattr(self, attr, attrs[attr])
del attrs[attr]
else:
@@ -701,7 +701,7 @@ class Option:
def _check_callback(self):
if self.action == "callback":
- if not callable(self.callback):
+ if not hasattr(self.callback, '__call__'):
raise OptionError(
"callback not callable: %r" % self.callback, self)
if (self.callback_args is not None and
@@ -817,12 +817,6 @@ class Option:
SUPPRESS_HELP = "SUPPRESS"+"HELP"
SUPPRESS_USAGE = "SUPPRESS"+"USAGE"
-# For compatibility with Python 2.2
-try:
- True, False
-except NameError:
- (True, False) = (1, 0)
-
try:
basestring
except NameError:
@@ -860,7 +854,7 @@ class Values:
are silently ignored.
"""
for attr in dir(self):
- if dict.has_key(attr):
+ if attr in dict:
dval = dict[attr]
if dval is not None:
setattr(self, attr, dval)
@@ -980,10 +974,10 @@ class OptionContainer:
def _check_conflict(self, option):
conflict_opts = []
for opt in option._short_opts:
- if self._short_opt.has_key(opt):
+ if opt in self._short_opt:
conflict_opts.append((opt, self._short_opt[opt]))
for opt in option._long_opts:
- if self._long_opt.has_key(opt):
+ if opt in self._long_opt:
conflict_opts.append((opt, self._long_opt[opt]))
if conflict_opts:
@@ -1029,7 +1023,7 @@ class OptionContainer:
if option.dest is not None: # option has a dest, we need a default
if option.default is not NO_DEFAULT:
self.defaults[option.dest] = option.default
- elif not self.defaults.has_key(option.dest):
+ elif option.dest not in self.defaults:
self.defaults[option.dest] = None
return option
@@ -1045,8 +1039,8 @@ class OptionContainer:
self._long_opt.get(opt_str))
def has_option(self, opt_str):
- return (self._short_opt.has_key(opt_str) or
- self._long_opt.has_key(opt_str))
+ return (opt_str in self._short_opt or
+ opt_str in self._long_opt)
def remove_option(self, opt_str):
option = self._short_opt.get(opt_str)
@@ -1664,7 +1658,7 @@ def _match_abbrev(s, wordmap):
'words', raise BadOptionError.
"""
# Is there an exact match?
- if wordmap.has_key(s):
+ if s in wordmap:
return s
else:
# Isolate all words with s as a prefix.