summaryrefslogtreecommitdiffstats
path: root/Lib/smtplib.py
diff options
context:
space:
mode:
authorR David Murray <rdmurray@bitdance.com>2014-08-30 20:51:59 (GMT)
committerR David Murray <rdmurray@bitdance.com>2014-08-30 20:51:59 (GMT)
commit0cff49fcf9b5689a8940c318ea0d846317f3a7d3 (patch)
tree6cfaf2c7f2cd5ae1bec06c6dabab72b23d3e9939 /Lib/smtplib.py
parenta64b92edd3b7c9145e014aac9a15821d7b05b71a (diff)
downloadcpython-0cff49fcf9b5689a8940c318ea0d846317f3a7d3.zip
cpython-0cff49fcf9b5689a8940c318ea0d846317f3a7d3.tar.gz
cpython-0cff49fcf9b5689a8940c318ea0d846317f3a7d3.tar.bz2
#22215: have the smtplib 'quit' command reset the state.
Without this reset, starttls would fail if a connect/starttls was done after a quit, because smtplib assumed the existing value of emspt_features was accurate, but it gets reset when starttls completes (and the new value does not contain the starttls capability, since tls is already started at that point). (There may be additional places where this lack of reset was an issue as well.) Patch by Milan Oberkirch.
Diffstat (limited to 'Lib/smtplib.py')
-rwxr-xr-xLib/smtplib.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/Lib/smtplib.py b/Lib/smtplib.py
index 759b77e..09b4ea6 100755
--- a/Lib/smtplib.py
+++ b/Lib/smtplib.py
@@ -866,6 +866,10 @@ class SMTP:
def quit(self):
"""Terminate the SMTP session."""
res = self.docmd("quit")
+ # A new EHLO is required after reconnecting with connect()
+ self.ehlo_resp = self.helo_resp = None
+ self.esmtp_features = {}
+ self.does_esmtp = False
self.close()
return res