diff options
| author | Amaury Forgeot d'Arc <amauryfa@gmail.com> | 2009-11-30 00:08:56 (GMT) |
|---|---|---|
| committer | Amaury Forgeot d'Arc <amauryfa@gmail.com> | 2009-11-30 00:08:56 (GMT) |
| commit | 7d0bddde5caca7abf41aa3d8763bc99ad8aa8798 (patch) | |
| tree | b8e31f1bf7954b3ccc9680c1c9ac7610b56ca382 /Lib/tempfile.py | |
| parent | acafc2d3d114fbbdf65bd1d77a6bbf39b94971f6 (diff) | |
| download | cpython-7d0bddde5caca7abf41aa3d8763bc99ad8aa8798.zip cpython-7d0bddde5caca7abf41aa3d8763bc99ad8aa8798.tar.gz cpython-7d0bddde5caca7abf41aa3d8763bc99ad8aa8798.tar.bz2 | |
#6077: on Windows, fix truncation of a tempfile.TemporaryFile opened in "wt+" mode:
files opened with os.open() stop on the first \x1a (Ctrl-Z) unless os.O_BINARY is used.
Will backport to 3.1
Diffstat (limited to 'Lib/tempfile.py')
| -rw-r--r-- | Lib/tempfile.py | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/Lib/tempfile.py b/Lib/tempfile.py index 93405a8..049cdaa 100644 --- a/Lib/tempfile.py +++ b/Lib/tempfile.py @@ -169,7 +169,6 @@ def _get_default_tempdir(): namer = _RandomNameSequence() dirlist = _candidate_tempdir_list() - flags = _text_openflags for dir in dirlist: if dir != _os.curdir: @@ -179,7 +178,7 @@ def _get_default_tempdir(): name = next(namer) filename = _os.path.join(dir, name) try: - fd = _os.open(filename, flags, 0o600) + fd = _os.open(filename, _bin_openflags, 0o600) fp = _io.open(fd, 'wb') fp.write(b'blat') fp.close() @@ -434,10 +433,7 @@ def NamedTemporaryFile(mode='w+b', buffering=-1, encoding=None, if dir is None: dir = gettempdir() - if 'b' in mode: - flags = _bin_openflags - else: - flags = _text_openflags + flags = _bin_openflags # Setting O_TEMPORARY in the flags causes the OS to delete # the file when it is closed. This is only supported by Windows. @@ -475,10 +471,7 @@ else: if dir is None: dir = gettempdir() - if 'b' in mode: - flags = _bin_openflags - else: - flags = _text_openflags + flags = _bin_openflags (fd, name) = _mkstemp_inner(dir, prefix, suffix, flags) try: |