diff options
author | Irit Katriel <1055913+iritkatriel@users.noreply.github.com> | 2024-05-01 11:01:16 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-01 11:01:16 (GMT) |
commit | c1bf4874c1e9db2beda1d62c8c241229783c789b (patch) | |
tree | 9a03e0d5d1e32979489f84319484e7a62e0ed352 /Lib/test/test_syntax.py | |
parent | f6fab21721c8aedc5dca97dbeb6292a067c19bf1 (diff) | |
download | cpython-c1bf4874c1e9db2beda1d62c8c241229783c789b.zip cpython-c1bf4874c1e9db2beda1d62c8c241229783c789b.tar.gz cpython-c1bf4874c1e9db2beda1d62c8c241229783c789b.tar.bz2 |
gh-116767: fix crash on 'async with' with many context managers (GH-118348)
Account for `add_stopiteration_handler` pushing a block for `async with`.
To allow generator functions that previously almost hit the `CO_MAXBLOCKS`
limit by nesting non-async blocks, the limit is increased by 1.
This increase allows one more block in non-generator functions.
Diffstat (limited to 'Lib/test/test_syntax.py')
-rw-r--r-- | Lib/test/test_syntax.py | 36 |
1 files changed, 32 insertions, 4 deletions
diff --git a/Lib/test/test_syntax.py b/Lib/test/test_syntax.py index e9bec33..de783f7 100644 --- a/Lib/test/test_syntax.py +++ b/Lib/test/test_syntax.py @@ -2392,13 +2392,40 @@ if x: code += "): yield a" return code - CO_MAXBLOCKS = 20 # static nesting limit of the compiler + CO_MAXBLOCKS = 21 # static nesting limit of the compiler + MAX_MANAGERS = CO_MAXBLOCKS - 1 # One for the StopIteration block - for n in range(CO_MAXBLOCKS): + for n in range(MAX_MANAGERS): with self.subTest(f"within range: {n=}"): compile(get_code(n), "<string>", "exec") - for n in range(CO_MAXBLOCKS, CO_MAXBLOCKS + 5): + for n in range(MAX_MANAGERS, MAX_MANAGERS + 5): + with self.subTest(f"out of range: {n=}"): + self._check_error(get_code(n), "too many statically nested blocks") + + @support.cpython_only + def test_async_with_statement_many_context_managers(self): + # See gh-116767 + + def get_code(n): + code = [ textwrap.dedent(""" + async def bug(): + async with ( + a + """) ] + for i in range(n): + code.append(f" as a{i}, a\n") + code.append("): yield a") + return "".join(code) + + CO_MAXBLOCKS = 21 # static nesting limit of the compiler + MAX_MANAGERS = CO_MAXBLOCKS - 1 # One for the StopIteration block + + for n in range(MAX_MANAGERS): + with self.subTest(f"within range: {n=}"): + compile(get_code(n), "<string>", "exec") + + for n in range(MAX_MANAGERS, MAX_MANAGERS + 5): with self.subTest(f"out of range: {n=}"): self._check_error(get_code(n), "too many statically nested blocks") @@ -2536,7 +2563,8 @@ while 1: while 20: while 21: while 22: - break + while 23: + break """ self._check_error(source, "too many statically nested blocks") |