summaryrefslogtreecommitdiffstats
path: root/Lib/test/test_tools
diff options
context:
space:
mode:
authorStefano Rivera <stefano@rivera.za.net>2024-06-12 19:19:36 (GMT)
committerGitHub <noreply@github.com>2024-06-12 19:19:36 (GMT)
commit030b452e34bbb0096acacb70a31915b9590c8186 (patch)
tree9dbb353d26a64a9ee5f241e06be4932cf9cd4d38 /Lib/test/test_tools
parent3453362183f083e37ea866a7ae1b34147ffaf81d (diff)
downloadcpython-030b452e34bbb0096acacb70a31915b9590c8186.zip
cpython-030b452e34bbb0096acacb70a31915b9590c8186.tar.gz
cpython-030b452e34bbb0096acacb70a31915b9590c8186.tar.bz2
gh-120418: Don't assume wheeldata is deleted if `WHEEL_PKG_DIR` is set (#120419)
Remove wheeldata from both sides of the `assertEqual`, so that we're *actually* ignoring it from the test set. This test is only making assertions about the source tree, no code is being executed that would do anything different based on the value of `WHEEL_PKG_DIR`.
Diffstat (limited to 'Lib/test/test_tools')
-rw-r--r--Lib/test/test_tools/test_makefile.py7
1 files changed, 4 insertions, 3 deletions
diff --git a/Lib/test/test_tools/test_makefile.py b/Lib/test/test_tools/test_makefile.py
index 48a7c1a..df95e6d 100644
--- a/Lib/test/test_tools/test_makefile.py
+++ b/Lib/test/test_tools/test_makefile.py
@@ -41,7 +41,7 @@ class TestMakefile(unittest.TestCase):
idle_test = 'idlelib/idle_test'
self.assertIn(idle_test, test_dirs)
- used = [idle_test]
+ used = set([idle_test])
for dirpath, dirs, files in os.walk(support.TEST_HOME_DIR):
dirname = os.path.basename(dirpath)
# Skip temporary dirs:
@@ -65,13 +65,14 @@ class TestMakefile(unittest.TestCase):
"of test directories to install"
)
)
- used.append(relpath)
+ used.add(relpath)
# Don't check the wheel dir when Python is built --with-wheel-pkg-dir
if sysconfig.get_config_var('WHEEL_PKG_DIR'):
test_dirs.remove('test/wheeldata')
+ used.discard('test/wheeldata')
# Check that there are no extra entries:
unique_test_dirs = set(test_dirs)
- self.assertSetEqual(unique_test_dirs, set(used))
+ self.assertSetEqual(unique_test_dirs, used)
self.assertEqual(len(test_dirs), len(unique_test_dirs))