diff options
| author | Victor Stinner <vstinner@python.org> | 2022-10-12 15:26:21 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-12 15:26:21 (GMT) |
| commit | a8c8526fd8ce2f3f50837bbbb820741e54b58512 (patch) | |
| tree | 247722821cc188088a31d3e1d76a6af2bc6e3e0f /Lib/test/test_tools | |
| parent | 0895c2a066c64c84cab0821886dfa66efc1bdc2f (diff) | |
| download | cpython-a8c8526fd8ce2f3f50837bbbb820741e54b58512.zip cpython-a8c8526fd8ce2f3f50837bbbb820741e54b58512.tar.gz cpython-a8c8526fd8ce2f3f50837bbbb820741e54b58512.tar.bz2 | |
gh-97669: Fix test_tools reference leak (#98216)
test_tools.test_sundry() now uses an unittest mock to prevent the
logging module to register a real "atfork" function which kept the
logging module dictionary alive. So the logging module can be
properly unloaded. Previously, the logging module was loaded before
test_sundry(), but it's no longer the case since recent test_tools
sub-tests removals.
Diffstat (limited to 'Lib/test/test_tools')
| -rw-r--r-- | Lib/test/test_tools/test_sundry.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/Lib/test/test_tools/test_sundry.py b/Lib/test/test_tools/test_sundry.py index 04e38ac..81f0676 100644 --- a/Lib/test/test_tools/test_sundry.py +++ b/Lib/test/test_tools/test_sundry.py @@ -27,7 +27,11 @@ class TestSundryScripts(unittest.TestCase): skiplist = denylist + allowlist + other - def test_sundry(self): + # import logging registers "atfork" functions which keep indirectly the + # logging module dictionary alive. Mock the function to be able to unload + # cleanly the logging module. + @import_helper.mock_register_at_fork + def test_sundry(self, mock_os): old_modules = import_helper.modules_setup() try: for fn in os.listdir(scriptsdir): |