diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2015-04-10 10:29:28 (GMT) |
|---|---|---|
| committer | Serhiy Storchaka <storchaka@gmail.com> | 2015-04-10 10:29:28 (GMT) |
| commit | 2116b12da59f77358cc539b90f58a3cdea43c2fd (patch) | |
| tree | 693d26652b1dbf8b2ac058c5725f9726c3d14a0b /Lib/urllib | |
| parent | fcbf8f3e3d46eb023dd9a3954c6f9ed9a533d427 (diff) | |
| parent | 7e7a3dba5fd4262269f713dfe21ba7e4746fc2dd (diff) | |
| download | cpython-2116b12da59f77358cc539b90f58a3cdea43c2fd.zip cpython-2116b12da59f77358cc539b90f58a3cdea43c2fd.tar.gz cpython-2116b12da59f77358cc539b90f58a3cdea43c2fd.tar.bz2 | |
Issue #23865: close() methods in multiple modules now are idempotent and more
robust at shutdown. If needs to release multiple resources, they are released
even if errors are occured.
Diffstat (limited to 'Lib/urllib')
| -rw-r--r-- | Lib/urllib/response.py | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/Lib/urllib/response.py b/Lib/urllib/response.py index 4a143b0..4778118 100644 --- a/Lib/urllib/response.py +++ b/Lib/urllib/response.py @@ -43,11 +43,15 @@ class addclosehook(addbase): self.hookargs = hookargs def close(self): - if self.closehook: - self.closehook(*self.hookargs) - self.closehook = None - self.hookargs = None - super(addclosehook, self).close() + try: + closehook = self.closehook + hookargs = self.hookargs + if closehook: + self.closehook = None + self.hookargs = None + closehook(*hookargs) + finally: + super(addclosehook, self).close() class addinfo(addbase): |