summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2017-01-13 07:10:51 (GMT)
committerSerhiy Storchaka <storchaka@gmail.com>2017-01-13 07:10:51 (GMT)
commit009b0a1face9c16b608b3cd18df8c88632006ae1 (patch)
tree632f8db681fec81723aee593a9d23318630862e9 /Lib
parentb37f3f6e6b17b32b9af4a5fcafc650580c94b2c9 (diff)
downloadcpython-009b0a1face9c16b608b3cd18df8c88632006ae1.zip
cpython-009b0a1face9c16b608b3cd18df8c88632006ae1.tar.gz
cpython-009b0a1face9c16b608b3cd18df8c88632006ae1.tar.bz2
Issue #29193: A format string argument for string.Formatter.format()
is now positional-only.
Diffstat (limited to 'Lib')
-rw-r--r--Lib/string.py10
-rw-r--r--Lib/test/test_string.py5
2 files changed, 4 insertions, 11 deletions
diff --git a/Lib/string.py b/Lib/string.py
index c902007..bc9508c 100644
--- a/Lib/string.py
+++ b/Lib/string.py
@@ -175,14 +175,8 @@ class Formatter:
try:
format_string, *args = args # allow the "format_string" keyword be passed
except ValueError:
- if 'format_string' in kwargs:
- format_string = kwargs.pop('format_string')
- import warnings
- warnings.warn("Passing 'format_string' as keyword argument is "
- "deprecated", DeprecationWarning, stacklevel=2)
- else:
- raise TypeError("format() missing 1 required positional "
- "argument: 'format_string'") from None
+ raise TypeError("format() missing 1 required positional "
+ "argument: 'format_string'") from None
return self.vformat(format_string, args, kwargs)
def vformat(self, format_string, args, kwargs):
diff --git a/Lib/test/test_string.py b/Lib/test/test_string.py
index 70439f8..a7b8aad 100644
--- a/Lib/test/test_string.py
+++ b/Lib/test/test_string.py
@@ -48,9 +48,8 @@ class ModuleTest(unittest.TestCase):
self.assertEqual(fmt.format("-{format_string}-", format_string='test'),
'-test-')
self.assertRaises(KeyError, fmt.format, "-{format_string}-")
- with self.assertWarnsRegex(DeprecationWarning, "format_string"):
- self.assertEqual(fmt.format(arg='test', format_string="-{arg}-"),
- '-test-')
+ with self.assertRaisesRegex(TypeError, "format_string"):
+ fmt.format(format_string="-{arg}-", arg='test')
def test_auto_numbering(self):
fmt = string.Formatter()