diff options
| author | Vo Hoang Long <vohoanglong07@gmail.com> | 2023-02-21 15:14:41 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-21 15:14:41 (GMT) |
| commit | 0d4c7fcd4f078708a5ac6499af378ce5ee8eb211 (patch) | |
| tree | 8eee1990e04156e58947481ceaf556f8f646b8b0 /Lib | |
| parent | c2b85a95a50687a2e5d1873e17266370876e77e9 (diff) | |
| download | cpython-0d4c7fcd4f078708a5ac6499af378ce5ee8eb211.zip cpython-0d4c7fcd4f078708a5ac6499af378ce5ee8eb211.tar.gz cpython-0d4c7fcd4f078708a5ac6499af378ce5ee8eb211.tar.bz2 | |
gh-101936: Update the default value of fp from io.StringIO to io.BytesIO (gh-102100)
Co-authored-by: Long Vo <long.vo@linecorp.com>
Diffstat (limited to 'Lib')
| -rw-r--r-- | Lib/test/test_urllib2.py | 1 | ||||
| -rw-r--r-- | Lib/urllib/error.py | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/Lib/test/test_urllib2.py b/Lib/test/test_urllib2.py index 498c038..633d596 100644 --- a/Lib/test/test_urllib2.py +++ b/Lib/test/test_urllib2.py @@ -1827,6 +1827,7 @@ class MiscTests(unittest.TestCase): def test_gh_98778(self): x = urllib.error.HTTPError("url", 405, "METHOD NOT ALLOWED", None, None) self.assertEqual(getattr(x, "__notes__", ()), ()) + self.assertIsInstance(x.fp.read(), bytes) def test_parse_proxy(self): parse_proxy_test_cases = [ diff --git a/Lib/urllib/error.py b/Lib/urllib/error.py index feec0e7..a9cd1ec 100644 --- a/Lib/urllib/error.py +++ b/Lib/urllib/error.py @@ -43,7 +43,7 @@ class HTTPError(URLError, urllib.response.addinfourl): self.fp = fp self.filename = url if fp is None: - fp = io.StringIO() + fp = io.BytesIO() self.__super_init(fp, hdrs, url, code) def __str__(self): |