summaryrefslogtreecommitdiffstats
path: root/Lib
diff options
context:
space:
mode:
authorSenthil Kumaran <orsenthil@gmail.com>2010-05-01 08:32:23 (GMT)
committerSenthil Kumaran <orsenthil@gmail.com>2010-05-01 08:32:23 (GMT)
commit5a3bc6533c80c17842554678dde469bca23f9501 (patch)
treef924e67ef745cde2cde1075b0dd308a11308cf29 /Lib
parenta751c3fcb85b91772485b87948ef45477d01a61a (diff)
downloadcpython-5a3bc6533c80c17842554678dde469bca23f9501.zip
cpython-5a3bc6533c80c17842554678dde469bca23f9501.tar.gz
cpython-5a3bc6533c80c17842554678dde469bca23f9501.tar.bz2
Merged revisions 80677 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k ................ r80677 | senthil.kumaran | 2010-05-01 13:59:18 +0530 (Sat, 01 May 2010) | 9 lines Merged revisions 80675 via svnmerge from svn+ssh://pythondev@svn.python.org/python/trunk ........ r80675 | senthil.kumaran | 2010-05-01 13:31:56 +0530 (Sat, 01 May 2010) | 3 lines Fix issue8582: urllib.urlretrieve fails with ValueError: Invalid format string ........ ................
Diffstat (limited to 'Lib')
-rw-r--r--Lib/test/test_urllibnet.py11
-rw-r--r--Lib/urllib/request.py2
2 files changed, 12 insertions, 1 deletions
diff --git a/Lib/test/test_urllibnet.py b/Lib/test/test_urllibnet.py
index 63e061a..37cad42 100644
--- a/Lib/test/test_urllibnet.py
+++ b/Lib/test/test_urllibnet.py
@@ -8,6 +8,7 @@ import urllib.request
import sys
import os
import email.message
+import time
def _open_with_retry(func, host, *args, **kwargs):
@@ -180,6 +181,16 @@ class urlretrieveNetworkTests(unittest.TestCase):
self.assertTrue(isinstance(header, email.message.Message),
"header is not an instance of email.message.Message")
+ def test_data_header(self):
+ logo = "http://www.python.org/community/logos/python-logo-master-v3-TM.png"
+ file_location, fileheaders = self.urlretrieve(logo)
+ os.unlink(file_location)
+ datevalue = fileheaders.get('Date')
+ dateformat = '%a, %d %b %Y %H:%M:%S GMT'
+ try:
+ time.strptime(datevalue, dateformat)
+ except ValueError:
+ self.fail('Date value not in %r format', dateformat)
def test_main():
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
index 0f9e2f8..002e326 100644
--- a/Lib/urllib/request.py
+++ b/Lib/urllib/request.py
@@ -1781,7 +1781,7 @@ class URLopener:
else:
encoding = ''
msg = []
- msg.append('Date: %s'%time.strftime('%a, %d %b %Y %T GMT',
+ msg.append('Date: %s'%time.strftime('%a, %d %b %Y %H:%M:%S GMT',
time.gmtime(time.time())))
msg.append('Content-type: %s' % type)
if encoding == 'base64':